Revert "SYNC-5090 - Remove probe-scraper for fxa-client" #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fd924dd. Removing fxa-client from repositories.yaml causes the mozilla_schema_generator Airflow task to fail. The generated schemas no longer include the fxa_client metrics columns (operation_count, error_count), which triggers BigQuery schema incompatibility validation.
akkomar
requested review from
Dexterp37,
badboy,
chutten,
mikaeld,
travis79 and
whd
as code owners
badboy
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #986.
Removing fxa-client from repositories.yaml causes the mozilla_schema_generator Airflow task to fail. The generated schemas no longer include the fxa_client metrics columns (operation_count, error_count), which triggers BigQuery schema incompatibility validation.
I think the best approach to deprecate these metrics would be to keep an empty metrics.yaml in application-services (as suggested in the original PR) so columns remain in schemas.
cc @badboy @bendk