Bug 2024765 - Remove redundant significance column #1018
Open
mgaudet wants to merge 2 commits intomozilla:mainfrom
Open
Bug 2024765 - Remove redundant significance column #1018mgaudet wants to merge 2 commits intomozilla:mainfrom
mgaudet wants to merge 2 commits intomozilla:mainfrom
Conversation
…page It's superflous for Mann-Whitney-U because the backend already only says improvement or regression for significant things! https://github.com/mozilla/treeherder/blob/5ba54899aa7d4b09668446af002e020779288a8a/treeherder/perf/stats.py#L320-L339
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 109 109
Lines 3051 3051
Branches 691 691
=======================================
Hits 2943 2943
Misses 107 107
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split into two commits for ease of review.