Skip to content

Bug 2024042 - Add median diff column#1015

Open
mgaudet wants to merge 1 commit intomozilla:mainfrom
mgaudet:median-diff
Open

Bug 2024042 - Add median diff column#1015
mgaudet wants to merge 1 commit intomozilla:mainfrom
mgaudet:median-diff

Conversation

@mgaudet
Copy link

@mgaudet mgaudet commented Mar 17, 2026

Allow sorting by magnitude for Mann Whitney U

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for mozilla-perfcompare ready!

Name Link
🔨 Latest commit 65bf544
🔍 Latest deploy log https://app.netlify.com/projects/mozilla-perfcompare/deploys/69b9c678b126f200081a3845
😎 Deploy Preview https://deploy-preview-1015--mozilla-perfcompare.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mgaudet
Copy link
Author

mgaudet commented Mar 17, 2026

One thing that I'm not sure how to handle: Adding the extra column has broken the layout a bit:
image

@kala-moz
Copy link
Contributor

kala-moz commented Mar 17, 2026

One thing that I'm not sure how to handle: Adding the extra column has broken the layout a bit: image

@mgaudet To resolve, I suggest using acronyms so MD(%) and write the full name in the tooltips. We'd also have to use CLES(%) for Effect Size. No need to add more info in the tooltip since it's already there.

Screenshot 2026-03-17 at 3 43 34 PM

Also, can you please run npm run fix-all to fix the tests, snapshots, etc.

Copy link
Contributor

@gmierz gmierz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this in the expanded row instead for each of the rows there (mean/median/variance/etc.)? We'd like to move away from focusing on the delta/magnitude of the change and having it at the row header goes against that. I can see it being useful though and having it in the expanded row would solve that if you ever need the number.

@mgaudet
Copy link
Author

mgaudet commented Mar 19, 2026

Not sure how to deal with stacked diffs here; but i have addressed feedback and have updates but on top of #1018 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants