Skip to content

Stripe users may have multiple roles #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bheesham merged 2 commits into from
Sep 18, 2026
Merged

Stripe users may have multiple roles #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c1037
lint: without specifying we'd declare it as a var
bheesham Sep 17, 2026
e435339
stripe: Users may have multiple roles assigned
bheesham Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tf/actions/samlMappings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,20 +99,29 @@ exports.onExecutePostLogin = async (event, api) => {
roles: [{ role: "view_only", account: "acct_1EJOaaJNcmPzuWtR" }],
},
];
// Each user may have multiple roles assigned to them per account.
// We gather each of their assigned roles, and then assert it afterwards.
const accountRoles = {};
for (const rule of groupToRoles) {
const usersAllowed = rule.users ?? [];
const isAllowedByEmail = usersAllowed.includes(event.user.email);
const isAllowedByGroup = userGroups.includes(rule.group);
if (!(isAllowedByEmail || isAllowedByGroup)) {
continue;
}
// Gather the user's roles in each account.
for (const role of rule.roles) {
api.samlResponse.setAttribute(
`Stripe-Role-${role.account}`,
role.role
);
const account = `Stripe-Role-${role.account}`;
if (account in accountRoles) {
accountRoles[account].push(role.role);
} else {
accountRoles[account] = [role.role];
}
}
}
for (const account in accountRoles) {
api.samlResponse.setAttribute(account, accountRoles[account]);
}
break;
}
// acoustic-stage, acoustic-prod
Expand Down
20 changes: 17 additions & 3 deletions tf/tests/samlMappings.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ describe("Stripe-Subplat SAML tests", () => {
_event.user.app_metadata.groups = _event.user.app_metadata.groups || [];
_event.user.app_metadata.groups.push(group);
expectedSamlAttributes = {
"Stripe-Role-acct_1EJOaaJNcmPzuWtR": role,
"Stripe-Role-acct_1EJOaaJNcmPzuWtR": [role],
};
} else {
delete _event.user.groups;
Expand All @@ -355,7 +355,21 @@ describe("Stripe-Subplat SAML tests", () => {
_event.client.client_id = "cEfnJekrSStxxxBascTjNEDAZVUPAIU2";
_event.user.email = "araccounting@mozilla.com";
const expectedSamlAttributes = {
"Stripe-Role-acct_1EJOaaJNcmPzuWtR": "admin",
"Stripe-Role-acct_1EJOaaJNcmPzuWtR": ["admin"],
};
await onExecutePostLogin(_event, api);
expect(api.samlResponse.setAttribute).toHaveBeenCalled();
expect(_samlAttributes).toEqual(expectedSamlAttributes);
});

test("User with multiple roles", async () => {
_event.client.client_id = "cEfnJekrSStxxxBascTjNEDAZVUPAIU2";
_event.user.app_metadata.groups = [
"mozilliansorg_stripe_subplat_analyst",
"mozilliansorg_stripe_subplat_viewonly",
];
const expectedSamlAttributes = {
"Stripe-Role-acct_1EJOaaJNcmPzuWtR": ["analyst", "view_only"],
};
await onExecutePostLogin(_event, api);
expect(api.samlResponse.setAttribute).toHaveBeenCalled();
Expand All @@ -374,7 +388,7 @@ describe("Acoustic SAML tests", () => {
async (clientID) => {
_event.client.client_id = clientID;

expectedSamlAttributes = {
const expectedSamlAttributes = {
Nameid: _event.user.email,
email: _event.user.email,
firstName: _event.user.given_name,
Expand Down