Repository navigation
Accept G91.1 in post read-back and mill audits - #152
Merged
mountainarcwelding merged 1 commit intoNov 10, 2026
Merged
mountainarcwelding merged 1 commit into
mountainarcwelding merged 1 commit into
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom Mach3 post header containing
G91.1could generate G-code but then fail its automatic read-back with “G code is not an integer”, preventing CLI output.Accept
G91.1as confirmation of incremental IJK centres inread_back,audit, andaudit_five. RejectG90.1with a specific unsupported-absolute-centres diagnostic. Endpoint positioning, built-in headers, and writer behavior are unchanged; absolute arc centres remain outside this change.Regression coverage exercises custom-header/full-circle round-tripping, unchanged arc and helix geometry, declaration placement and equivalent numeric spelling, unsupported codes, and existing router probe support.
Validation on Linux (Rust 1.95):
arc_centre_modetests passed.scripts/check.shpassed: formatting, workspace Clippy with warnings denied, workspace tests, wasm library checks, and license checks.G91.1plus valid IR JSON.AI disclosure: this patch, tests, review, and validation were developed with AI assistance using CAMpanion sources and synthetic inputs, following the repository's clean-room contributor rules. No physical controller testing was performed.
Fixes #144.