Repository navigation
Accept G53 machine retracts in mill audit - #153
Merged
mountainarcwelding merged 2 commits intoNov 10, 2026
Merged
mountainarcwelding merged 2 commits into
mountainarcwelding merged 2 commits into
Conversation
Owner
Resolve changelog, post README, and audit.rs docs so both the G91.1 and G53 notes remain. Keep the 91.1/90.1 match arms above the integer G parse, then the G53 early return. Co-authored-by: DarkBiscuits <darkbiscuitstuff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom mill tool-change template containing
G53 G0 Z0posts and passes read-back, but millauditrejects it asunsupported G53.Accept G53 in mill audit as a non-modal machine-coordinate move, excluded from part-frame motions. Preserve the preceding part position, motion mode and plane so a machine retract does not corrupt subsequent modal lines or arcs. Validate the block's words before skipping its machine-coordinate motion. This follows the existing read-back/five-axis treatment and does not model a machine-to-work transform or verify the physical retract path.
Regression coverage includes a posted custom tool-change template with IR round-trip, modal arcs following retracts (including reordered words and plane words), malformed-word rejection, and randomized machine coordinates followed by a partially specified modal feed move. The three positive regression tests failed with
unsupported G53before the fix.Validation on Linux (Rust 1.95):
mill_g53tests passed, including the property test.scripts/check.shpassed: formatting, workspace Clippy with warnings denied, workspace tests, wasm library checks, and licenses.AI disclosure: implementation, regression tests, review, and validation were performed with AI assistance using CAMpanion's own sources and synthetic inputs, following the clean-room contribution rules. No physical controller testing was performed.
This branch starts from upstream main and is independent of #152.
Fixes #145.