Repository navigation
Conversation
1 of 3 tasks
moetemp
force-pushed
the
moe/brook/review/k6-service-writes
branch
from
October 25, 2026 22:10
f1d79a2 to
9aac2a2
Compare
moetemp
force-pushed
the
moe/brook/review/k5-redis-store
branch
2 times, most recently
from
October 25, 2026 22:17
4be1ac8 to
d351adb
Compare
moetemp
force-pushed
the
moe/brook/review/k6-service-writes
branch
from
October 25, 2026 22:17
9aac2a2 to
8254580
Compare
moetemp
force-pushed
the
moe/brook/review/k5-redis-store
branch
from
October 26, 2026 01:08
d351adb to
efebb98
Compare
moetemp
force-pushed
the
moe/brook/review/k6-service-writes
branch
from
October 26, 2026 01:08
8254580 to
7bf983c
Compare
The runtime is a plain object that a bridge builds per client and calls with a method name and proto bytes. The service checks each request and the Store's capabilities before it writes.
moetemp
force-pushed
the
moe/brook/review/k6-service-writes
branch
from
October 26, 2026 08:00
7bf983c to
e34b7eb
Compare
Owner
Author
|
Moved to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR serves the Stream service writes and describe through the runtime object.
StreamRuntimeper client and calls it with a method name and proto bytes.Core has no hook for it, and a Workflow makes each call from a Local Activity.
RUN_FENCEuntil K7, so a retry run's write fails withstream_unsupported.Depends on #47 (K5). Review lane is the Rust reviewers.
Part of the Brook review series.
Why?
Every SDK calls the write path first, and it needs no read code. Reads get their own PR (K8).
How did you test it?
cargo fmt,clippy(both feature sets),cargo teston memory, Redis 8 and 7.0. Fork CI passes.Link to a test plan if any -