Repository navigation
Conversation
1 of 3 tasks
moetemp
force-pushed
the
moe/brook/review/k6-service-writes
branch
from
October 25, 2026 22:10
f1d79a2 to
9aac2a2
Compare
moetemp
force-pushed
the
moe/brook/review/k8-reads
branch
from
October 25, 2026 22:10
7005750 to
008f1c7
Compare
moetemp
force-pushed
the
moe/brook/review/k6-service-writes
branch
from
October 25, 2026 22:17
9aac2a2 to
8254580
Compare
moetemp
force-pushed
the
moe/brook/review/k8-reads
branch
2 times, most recently
from
October 26, 2026 01:08
6941b5e to
7c47aa6
Compare
moetemp
force-pushed
the
moe/brook/review/k6-service-writes
branch
from
October 26, 2026 01:08
8254580 to
7bf983c
Compare
A read waits for the create and for new Records, scans a bounded part of the log per page, and fails on a gap that the Retention left. The service tests that read back what the writes stored come here too.
moetemp
force-pushed
the
moe/brook/review/k6-service-writes
branch
from
October 26, 2026 08:00
7bf983c to
e34b7eb
Compare
moetemp
force-pushed
the
moe/brook/review/k8-reads
branch
from
October 26, 2026 08:00
7c47aa6 to
5a80b63
Compare
Owner
Author
|
Moved to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR serves
ReadRecords, with long polls, Topic filters, last-N reads and byte caps.to_offsetandwake_onlyfail withstream_unsupported, since only the native serverserves them.
Depends on #48 (K6), and K7 is based on it. Review lane is the Rust reviewers.
Part of the Brook review series.
Why?
Reads are about half of the service. The long poll and the scan cap need the most review time.
How did you test it?
cargo fmt,clippy(both feature sets),cargo teston memory, Redis 8 and 7.0. Fork CI passes.Link to a test plan if any -