Repository navigation
Conversation
1 of 3 tasks
moetemp
force-pushed
the
moe/brook/review/k3-store-trait
branch
3 times, most recently
from
October 26, 2026 01:08
cac83a3 to
2d43c5c
Compare
A Store declares the rules it applies atomically beyond the log, and the service refuses a call that needs a capability the Store lacks. The trait is small so that a native Store can implement it too.
moetemp
force-pushed
the
moe/brook/review/k3-store-trait
branch
from
October 26, 2026 08:00
2d43c5c to
c75d106
Compare
Owner
Author
|
Moved to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the
Storetrait, the stored Record and batch limits, and the Store capabilities.owner_chainreads a ref's ownerbusiness_idonly for a Workflow owner, for the close check.Depends on #44 (K2). Review lane is the Rust reviewers.
Part of the Brook review series.
Why?
The memory Store, the Redis Store and later a native Store implement this trait. A small PR keeps
the contract apart from any one Store.
How did you test it?
cargo fmt,clippy(both feature sets),cargo testand the FIPS tree check. Fork CI passes.Link to a test plan if any -