Repository navigation
Conversation
1 of 3 tasks
moetemp
force-pushed
the
moe/brook/review/k3-store-trait
branch
from
October 25, 2026 22:10
e468e9e to
b601b40
Compare
moetemp
force-pushed
the
moe/brook/review/k4-memory-store
branch
from
October 25, 2026 22:10
a6127cf to
5c5c7d9
Compare
moetemp
force-pushed
the
moe/brook/review/k3-store-trait
branch
from
October 25, 2026 22:17
b601b40 to
cac83a3
Compare
moetemp
force-pushed
the
moe/brook/review/k4-memory-store
branch
from
October 25, 2026 22:17
5c5c7d9 to
3a142d0
Compare
moetemp
force-pushed
the
moe/brook/review/k3-store-trait
branch
from
October 26, 2026 01:08
cac83a3 to
2d43c5c
Compare
moetemp
force-pushed
the
moe/brook/review/k4-memory-store
branch
from
October 26, 2026 01:08
3a142d0 to
14b96c0
Compare
The memory Store keeps the Redis layout and runs the steps of the Lua scripts in the same order, so that one suite checks both Stores. The retry run and orphan rules come later, so it lacks the run fence.
moetemp
force-pushed
the
moe/brook/review/k3-store-trait
branch
from
October 26, 2026 08:00
2d43c5c to
c75d106
Compare
moetemp
force-pushed
the
moe/brook/review/k4-memory-store
branch
from
October 26, 2026 08:00
14b96c0 to
a075c7f
Compare
Owner
Author
|
Moved to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the memory Store and the shared Store suite.
RUN_FENCE. K7 adds them to both Stores.Depends on #45 (K3). Review lane is the Redis and Lua reviewers, as the reference for K5 and K7.
Part of the Brook review series.
Why?
The same rules exist in Lua, in this Store, in
gen_vectors.pyand in the Jetty server. Plain Rustis easier to check first, and the suite fails when two Stores differ.
How did you test it?
cargo fmt,clippy(both feature sets),cargo testand the FIPS tree check. Fork CI passes.Link to a test plan if any -