Skip to content

[Brook K4] Added the memory Store and the shared Store suite. - #46

Closed
moetemp wants to merge 1 commit into
moe/brook/review/k3-store-traitfrom
moe/brook/review/k4-memory-store
Closed

moetemp wants to merge 1 commit into
moe/brook/review/k3-store-traitfrom
moe/brook/review/k4-memory-store

Conversation

@moetemp

@moetemp moetemp commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

What changed?

This PR adds the memory Store and the shared Store suite.

  • The memory Store keeps the Redis layout and runs the steps of the Lua scripts in the same order.
  • The suite runs on every Store, and each case names the guarantee it checks.
  • No retry run or orphan rules yet, so no RUN_FENCE. K7 adds them to both Stores.

Depends on #45 (K3). Review lane is the Redis and Lua reviewers, as the reference for K5 and K7.
Part of the Brook review series.

Why?

The same rules exist in Lua, in this Store, in gen_vectors.py and in the Jetty server. Plain Rust
is easier to check first, and the suite fails when two Stores differ.

How did you test it?

cargo fmt, clippy (both feature sets), cargo test and the FIPS tree check. Fork CI passes.

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

@moetemp
moetemp force-pushed the moe/brook/review/k3-store-trait branch from e468e9e to b601b40 Compare October 25, 2026 22:10
@moetemp
moetemp force-pushed the moe/brook/review/k4-memory-store branch from a6127cf to 5c5c7d9 Compare October 25, 2026 22:10
@moetemp
moetemp force-pushed the moe/brook/review/k3-store-trait branch from b601b40 to cac83a3 Compare October 25, 2026 22:17
@moetemp
moetemp force-pushed the moe/brook/review/k4-memory-store branch from 5c5c7d9 to 3a142d0 Compare October 25, 2026 22:17
@moetemp
moetemp force-pushed the moe/brook/review/k3-store-trait branch from cac83a3 to 2d43c5c Compare October 26, 2026 01:08
@moetemp
moetemp force-pushed the moe/brook/review/k4-memory-store branch from 3a142d0 to 14b96c0 Compare October 26, 2026 01:08
The memory Store keeps the Redis layout and runs the steps of the Lua
scripts in the same order, so that one suite checks both Stores. The
retry run and orphan rules come later, so it lacks the run fence.
@moetemp
moetemp force-pushed the moe/brook/review/k3-store-trait branch from 2d43c5c to c75d106 Compare October 26, 2026 08:00
@moetemp
moetemp force-pushed the moe/brook/review/k4-memory-store branch from 14b96c0 to a075c7f Compare October 26, 2026 08:00
@moetemp

moetemp commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

Moved to moetemp/sdk-rust#215 (K4). The crate split in two. The shared runtime is now the crate temporalio-streams in sdk-rust (moetemp/sdk-rust#212 to #220), and the Redis Store is temporalio-streams-redis in temporal-community/sdk-streams (#1 to #3).

@moetemp moetemp closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant