Repository navigation
Conversation
1 of 3 tasks
These are the rules that every SDK and the server must compute the same way. `testdata/gen_vectors.py` writes the shared vectors from a second implementation, and `tests/vectors.rs` checks the crate on them.
moetemp
force-pushed
the
moe/brook/review/k1-skeleton
branch
from
October 26, 2026 08:00
6c8ca5c to
d81d3c6
Compare
moetemp
force-pushed
the
moe/brook/review/k2-ids-vectors
branch
from
October 26, 2026 08:00
ea47ddd to
5fe2b28
Compare
Owner
Author
|
Moved to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the Stream ids, offsets, epoch keys and batch digest, with shared vectors.
<ms>-<seq>asms << 20 | seq.testdata/gen_vectors.pyis a second implementation. Each SDK and the server run its vectors.Depends on #43 (K1). Review lane is the Rust reviewers.
Part of the Brook review series.
Why?
Every SDK and the server must compute these the same way. They have no I/O, so reviewers can check
them against the vectors before any Store exists.
How did you test it?
cargo fmt,clippy(both feature sets),cargo testand the FIPS tree check. Fork CI passes.Link to a test plan if any -