Repository navigation
Conversation
This was referenced Oct 25, 2026
The crate builds on `temporalio-common` 1.1 from crates.io and generates only the Stream service and runtime protos. CI runs lint, the tests and the FIPS dependency check.
moetemp
force-pushed
the
moe/brook/review/k1-skeleton
branch
from
October 26, 2026 08:00
6c8ca5c to
d81d3c6
Compare
Owner
Author
|
Moved to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the
temporalio-streamscrate skeleton, the Stream protos and CI.temporalio/api#895). Their enums build here.temporalio-common1.1 from crates.io, with no git dependency on Core.fipsturns on the FIPS mode ofaws-lc-rs, and CI fails whenringis in that build.Depends on nothing. Review lane is the proto and WIT reviewers.
Part of the Brook review series.
Why?
The protos are the contract with every SDK, so they're first and alone. The crate needs nothing
unreleased from Core, so we can publish it on crates.io after review (KR).
How did you test it?
cargo fmt,clippy(both feature sets),cargo testand the FIPS tree check. Fork CI passes.Link to a test plan if any -