Skip to content

[Brook] feat(python): add the long-poll loop to the caller - #42

Closed
moetemp wants to merge 19 commits into
moe/brook/v3/n4-client-transportfrom
moe/brook/v3/n7-long-poll-loop
Closed

moetemp wants to merge 19 commits into
moe/brook/v3/n4-client-transportfrom
moe/brook/v3/n7-long-poll-loop

Conversation

@moetemp

@moetemp moetemp commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

What changed?

This PR adds the long-poll loop and the offset iterator to the Python caller. It merges #55, the upstream version.

Why?

Brook reads Streams with a long poll, and every reader needs this loop.

How did you test it?

Covered by #55: a sample test reads pages over a fake transport.

@moetemp
moetemp changed the base branch from moe/brook/v3/n6-python-stub-enum-imports to moe/brook/v3/n4-client-transport October 21, 2026 07:11
The caller repeats a long poll until it answers or a deadline passes, and reads an offset-based
long poll as an async iterator. The log-service sample shows both.
# Conflicts:
#	src/generator/python.rs
…long-poll-loop

# Conflicts:
#	src/generator/python.rs
#	tests/wit_streaming.rs
# Conflicts:
#	GUIDE.md
#	changelog/added/patient-pelican.md
#	src/generator/python.rs
#	src/parser/wit.rs
@moetemp moetemp changed the title [Brook] Added the long-poll loop to the Python caller. [Brook] Add the long-poll loop to the Python caller Oct 22, 2026
@moetemp moetemp changed the title [Brook] Add the long-poll loop to the Python caller feat(brook): add the long-poll loop to the Python caller Oct 22, 2026
@moetemp moetemp changed the title feat(brook): add the long-poll loop to the Python caller [Brook] feat(python): add the long-poll loop to the caller Oct 22, 2026
@moetemp

moetemp commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Closing as superseded. The long-poll loop goes upstream with UPSTREAM-9 (#55). Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f

@moetemp moetemp closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant