Repository navigation
Conversation
The Stream WIT no longer marks any operation one-way, so the parser, generator, tests, docs and changelog fragment go.
moetemp
changed the base branch from
moe/brook/v3/n3-one-way
to
moe/brook/v3/n2-long-poll-parsing
October 22, 2026 06:58
With --client, client.py has one caller per service for code outside a Workflow. The caller converts user values with a data converter, and a Transport carries each call.
…port # Conflicts: # GUIDE.md # src/generator/python.rs # xtask/src/build_examples.rs
moetemp
changed the title
moetemp
changed the title
moetemp
changed the title
Owner
Author
|
Closing as superseded. The Python caller over a transport goes upstream with UPSTREAM-8 (#54). Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
--client. The Python target writesclient.pywith one caller per service over aTransport, for code outside a Workflow. It merges #54, the upstream version.Why?
Brook's Activities and clients call the Stream service through the worker extension, so they need a caller over a transport they choose.
How did you test it?
Covered by #54: a sample test over a fake transport.