smoke: isolate and loop flaky Chat Sessions / Agents Window tests [do not merge]#322243
Draft
alexdima wants to merge 1 commit into
Draft
smoke: isolate and loop flaky Chat Sessions / Agents Window tests [do not merge]#322243alexdima wants to merge 1 commit into
alexdima wants to merge 1 commit into
Conversation
Temporary, do-not-merge investigation change to flush out smoke test flakiness. Disables all smoke suites except Chat Sessions and Agents Window in main.ts, and loops the Electron smoke test step 10 times on Linux, macOS and Windows so a single flaky failure fails the build while preserving uploaded logs/traces. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Temporary investigation PR intended to reproduce and diagnose flakiness in the Electron smoke tests for Chat Sessions and the Agents Window by narrowing the executed smoke suites and running them repeatedly in CI.
Changes:
- Commented out all smoke suites except Chat Sessions and Agents Window in
test/smoke/src/main.ts. - Updated Azure Pipelines (Linux/macOS/Windows) to loop the Electron smoke test step 10 times with an increased timeout to surface intermittent failures faster.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/src/main.ts | Disables most smoke suites, leaving only Chat Sessions + Agents Window setup enabled for Electron runs. |
| build/azure-pipelines/win32/steps/product-build-win32-test.yml | Loops Electron smoke tests 10× on Windows and increases timeout. |
| build/azure-pipelines/linux/steps/product-build-linux-test.yml | Loops Electron smoke tests 10× on Linux and increases timeout. |
| build/azure-pipelines/darwin/steps/product-build-darwin-test.yml | Loops Electron smoke tests 10× on macOS and increases timeout. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 4
Comment on lines
+123
to
+127
| for i in $(seq 1 10); do | ||
| echo "##[group]Smoke test run $i of 10" | ||
| npm run smoketest-no-compile -- --tracing --build "$(agent.builddirectory)/VSCode-linux-$(VSCODE_ARCH)" | ||
| echo "##[endgroup]" | ||
| done |
Comment on lines
+111
to
+115
| for i in $(seq 1 10); do | ||
| echo "##[group]Smoke test run $i of 10" | ||
| npm run smoketest-no-compile -- --tracing --build "$APP_ROOT/$APP_NAME" | ||
| echo "##[endgroup]" | ||
| done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Isolates the suspected flaky suites — in
test/smoke/src/main.ts, all smoke test suites are commented out except:setupChatSessionsTests(Chat Sessions)setupAgentsWindowTests(Agents Window, including local AgentHost / SDK sandbox / Codex variants)Loops the Electron smoke step 10× on all three platforms (Linux, macOS, Windows). Each iteration runs the smoke tests; on the first non-zero exit the loop fails fast so the build fails (e.g. at run 4) while the existing diagnostics/artifact-upload steps still run and preserve logs + traces.
set -e+for i in $(seq 1 10)$LASTEXITCODEafter each run (PowerShell does not auto-fail on external command exit codes)timeoutInMinutesbumped from 20 to 120 to accommodate 10 runsNotes for reviewers
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com