add exception to acl.kdump and acl.kdump.grub for qemu + aarch64 #29
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,21 +90,23 @@ tests: | |
| as linux.ntp). Covered by the containerd and chrony follow-up | ||
| tests tracked there. | ||
|
|
||
| - name: acl.kdump | ||
| exceptions: | ||
| - bootloader: [grub] | ||
| reason: acl.kdump requires UKI boot (addon-based crashkernel) | ||
| - platforms: [qemu] | ||
|
Member
There was a problem hiding this comment. Are we skipping for qemu both archs here, but only aarch64 for the grub flavor of the test on purpose?
Author
There was a problem hiding this comment. yes, if we want we can enable acl.kdump for qemu+amd64. thanks
Member
There was a problem hiding this comment. if that works reliably, then lets have it enabled consistently
Author
There was a problem hiding this comment. No worries, have enabled the test for qemu + amd64. https://dev.azure.com/mariner-org/ACL/_build/results?buildId=1179467&view=results |
||
| architectures: [aarch64] | ||
| reason: Crash dump under TCG emulation is too slow and I/O-variable to be reliable. | ||
|
|
||
| - name: acl.kdump.grub | ||
| exceptions: | ||
| - platforms: [azure] | ||
|
mayankfz marked this conversation as resolved.
|
||
| reason: writing /oem/grub.cfg does not persist across reboot on cloud platforms. | ||
| - bootloader: [uki] | ||
| reason: acl.kdump.grub is for GRUB images only | ||
| - platforms: [qemu] | ||
| architectures: [aarch64] | ||
| reason: Crash dump under TCG emulation is too slow and I/O-variable to be reliable. | ||
|
|
||
| - name: acl.ignition.v1.users | ||
| - name: acl.ignition.v2.users | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge order: these entries re-enable kdump enforcement, but the mantle-side enabling/managed-reboot change is still only in microsoft/azure-container-linux-mantle#25 (open). Build 1179466 consumed
acldevel.azurecr.io/mantle:latest; its log shows an intermediate PR #25 implementation (acl.kdump.grubstill fails at kdump.go:131 on UKI), rather than mantleaclmainor PR #25 current head. If this lands first andmantle:latestis rebuilt from mantleaclmain, both tests are again excluded for ACL and the evaluator can fail with "enforced test NOT SELECTED". Please merge #25 first, refresh the mantle image, rebase this branch, and rerun PR #29.