add exception to acl.kdump and acl.kdump.grub for qemu + aarch64 by mayankfz · Pull Request #29 · microsoft/azure-container-linux

mayankfz · 2026-07-10T08:43:11Z

Summary

add exception to acl.kdump for qemu + aarch64

Change Log

add exception to acl.kdump for qemu + aarch64

Type of Change

Does this affect the image build?

Yes
No

Associated Issues

Test details: https://dev.azure.com/mariner-org/ACL/_build/results?buildId=1197962&view=results

Merge Checklist

All applicable boxes should be checked before merging

Image builds successfully with this change (or image build is not affected)
Any updated packages/SPECs build successfully
Relevant kola tests pass
All package sources are available
Source files have up-to-date hashes/manifests
Documentation has been updated to match any changes
Ready to merge

Copilot

Pull request overview

This PR updates the enforced kola test policy to allow acl.kdump-related tests to be exempted on QEMU + aarch64, acknowledging that kdump validation under TCG emulation is not reliably actionable and that arm64 coverage is handled via Azure.

Changes:

Add an exception for acl.kdump on platforms: [qemu] + architectures: [aarch64].
Add an exception for acl.kdump.grub on platforms: [qemu] + architectures: [aarch64].

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

acl/tests/kola_enforcing.yaml:66

The PR title/description says this change only adds a QEMU+aarch64 exception for acl.kdump, but this diff also re-enables both acl.kdump and acl.kdump.grub in the enforced list and adds a matching QEMU+aarch64 exception for acl.kdump.grub. Please update the PR description (and optionally the title) to reflect the full scope so reviewers understand the behavioral change in enforcement.

  - name: acl.kdump
    exceptions:
      - bootloader: [grub]
        reason: acl.kdump requires UKI boot (addon-based crashkernel)
      - platforms: [qemu]
        architectures: [aarch64]
        reason: Crash dump under TCG emulation is too slow and I/O-variable to be reliable, aarch64 coverage via Azure.

  - name: acl.kdump.grub
    exceptions:

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

acl/tests/kola_enforcing.yaml:70

The PR title/description says this change adds an exception to acl.kdump for qemu + aarch64, but the new exception is attached to acl.kdump.grub (and this hunk also re-enables both acl.kdump and acl.kdump.grub in the enforcing list). Please either (a) move/add the qemu/aarch64 exception under acl.kdump if that’s what is intended, or (b) update the PR title/description/changelog to reflect that the exception is for acl.kdump.grub (and that both tests are being re-enabled).

  - name: acl.kdump.grub
    exceptions:
      - platforms: [azure]
        reason: writing /oem/grub.cfg does not persist across reboot on cloud platforms.
      - bootloader: [uki]
        reason: acl.kdump.grub is for GRUB images only
      - platforms: [qemu]
        architectures: [aarch64]
        reason: Crash dump under TCG emulation is too slow and I/O-variable to be reliable.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

acl/tests/kola_enforcing.yaml:72

The PR title/description mention adding an exception to acl.kdump, but this change also adds a new qemu+aarch64 exception for acl.kdump.grub. If both are required, the PR description should mention both test entries; otherwise consider dropping the acl.kdump.grub change to match the stated scope.

  - name: acl.kdump.grub
    exceptions:
      - platforms: [azure]
        reason: writing /oem/grub.cfg does not persist across reboot on cloud platforms.
      - bootloader: [uki]
        reason: acl.kdump.grub is for GRUB images only
      - platforms: [qemu]
        architectures: [aarch64]
        reason: Crash dump under TCG emulation is too slow and I/O-variable to be reliable.

acl/tests/kola_enforcing.yaml:62

The PR title/description call out an exception for qemu+aarch64, but this rule disables acl.kdump for all qemu architectures. If the intent is to only exempt the TCG-emulated arm64 case (as described), scope this exception with architectures: [aarch64] (or update the PR description if the broader exemption is intentional).

      - platforms: [qemu]
        reason: Crash dump cycle is too slow and I/O-variable for qemu CI.

Jiri Appl (jiria) · 2026-08-07T17:29:53Z

+    exceptions:
+      - bootloader: [grub]
+        reason: acl.kdump requires UKI boot (addon-based crashkernel)
+      - platforms: [qemu]


Are we skipping for qemu both archs here, but only aarch64 for the grub flavor of the test on purpose?

yes, if we want we can enable acl.kdump for qemu+amd64. thanks

if that works reliably, then lets have it enabled consistently

No worries, have enabled the test for qemu + amd64.
pipeline runs ->

https://dev.azure.com/mariner-org/ACL/_build/results?buildId=1179467&view=results
https://dev.azure.com/mariner-org/ACL/_build/results?buildId=1179477&view=results

Jiri Appl (jiria) · 2026-08-07T17:38:18Z

Kicked off https://dev.azure.com/mariner-org/ACL/_build/results?buildId=1177926&view=results to make sure we have a good run post reintroduction or if we should merge microsoft/azure-container-linux-mantle#25 first.

Jiri Appl (jiria) · 2026-08-08T14:33:32Z

Kicked off https://dev.azure.com/mariner-org/ACL/_build/results?buildId=1177926&view=results to make sure we have a good run post reintroduction or if we should merge microsoft/azure-container-linux-mantle#25 first.

QEMU aarch64 kdump is still slow sometimes, so I think we will need the mantle changes first:

--- FAIL: acl.kdump (4226.62s)

mayankfz · 2026-08-08T14:41:14Z

Kicked off https://dev.azure.com/mariner-org/ACL/_build/results?buildId=1177926&view=results to make sure we have a good run post reintroduction or if we should merge microsoft/azure-container-linux-mantle#25 first.

QEMU aarch64 kdump is still slow sometimes, so I think we will need the mantle changes first:
--- FAIL: acl.kdump (4226.62s)

Agreed

mayankfz · 2026-08-08T14:46:39Z

Latest run with the changes (acl-scripts + mantle) -> https://dev.azure.com/mariner-org/ACL/_build/results?buildId=1178396&view=results

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

acl/tests/kola_enforcing.yaml:73

PR title/description say this change is only an exception for acl.kdump on qemu+aarch64, but this hunk also re-enables acl.kdump/acl.kdump.grub enforcement (previously commented out) and adds the same qemu+aarch64 exception to acl.kdump.grub. If this broader scope is intended, the PR metadata should be updated to reflect it; otherwise consider limiting the change to just the intended test(s).

  - name: acl.kdump
    exceptions:
      - bootloader: [grub]
        reason: acl.kdump requires UKI boot (addon-based crashkernel)
      - platforms: [qemu]
        architectures: [aarch64]
        reason: Crash dump under TCG emulation is too slow and I/O-variable to be reliable.

  - name: acl.kdump.grub
    exceptions:
      - platforms: [azure]
        reason: writing /oem/grub.cfg does not persist across reboot on cloud platforms.
      - bootloader: [uki]
        reason: acl.kdump.grub is for GRUB images only
      - platforms: [qemu]
        architectures: [aarch64]
        reason: Crash dump under TCG emulation is too slow and I/O-variable to be reliable.

SeanDougherty · 2026-08-13T20:56:14Z

-  #       reason: writing /oem/grub.cfg does not persist across reboot on cloud platforms.
-  #     - bootloader: [uki]
-  #       reason: acl.kdump.grub is for GRUB images only
+  - name: acl.kdump


Blocking merge order: these entries re-enable kdump enforcement, but the mantle-side enabling/managed-reboot change is still only in microsoft/azure-container-linux-mantle#25 (open). Build 1179466 consumed acldevel.azurecr.io/mantle:latest; its log shows an intermediate PR #25 implementation (acl.kdump.grub still fails at kdump.go:131 on UKI), rather than mantle aclmain or PR #25 current head. If this lands first and mantle:latest is rebuilt from mantle aclmain, both tests are again excluded for ACL and the evaluator can fail with "enforced test NOT SELECTED". Please merge #25 first, refresh the mantle image, rebase this branch, and rerun PR #29.

Signed-off-by: Mayank Singh <mayansingh@microsoft.com>

Copilot

🟡 Changes recommended

The change scope in the PR title/description doesn’t match the code changes (it also modifies acl.kdump.grub), which needs clarification or adjustment before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Lite

mayankfz marked this pull request as ready for review July 10, 2026 08:45

mayankfz requested a review from a team as a code owner July 10, 2026 08:45

Copilot AI lite review requested due to automatic review settings July 10, 2026 08:45

Copilot started reviewing on behalf of mayankfz July 10, 2026 08:46 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 28, 2026 05:55

mayankfz force-pushed the mayansingh/kdump branch from 7be14bb to 1d8fcaf Compare July 28, 2026 05:55

Copilot started reviewing on behalf of mayankfz July 28, 2026 05:56 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 30, 2026 06:31

Copilot started reviewing on behalf of mayankfz July 30, 2026 06:31 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

mayankfz force-pushed the mayansingh/kdump branch from c249e93 to d978ea5 Compare July 30, 2026 06:36

Copilot AI review requested due to automatic review settings July 30, 2026 08:52

mayankfz force-pushed the mayansingh/kdump branch from d978ea5 to 57555f8 Compare July 30, 2026 08:52

Copilot started reviewing on behalf of mayankfz July 30, 2026 08:53 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

Jiri Appl (jiria) reviewed Aug 7, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings August 10, 2026 06:45

mayankfz force-pushed the mayansingh/kdump branch from 57555f8 to c551a31 Compare August 10, 2026 06:45

Copilot started reviewing on behalf of mayankfz August 10, 2026 06:46 View session

Copilot AI reviewed Aug 10, 2026

View reviewed changes

SeanDougherty reviewed Aug 13, 2026

View reviewed changes

Mayank Singh added 2 commits September 7, 2026 07:50

add exception to acl.kdump for qemu + aarch64

e96c503

Signed-off-by: Mayank Singh <mayansingh@microsoft.com>

kdump test enabled but not scheduled for qemu

c34e10e

Copilot AI review requested due to automatic review settings September 7, 2026 07:50

mayankfz force-pushed the mayansingh/kdump branch from c551a31 to c34e10e Compare September 7, 2026 07:50

Copilot started reviewing on behalf of mayankfz September 7, 2026 07:51 View session

Copilot AI reviewed Sep 7, 2026

View reviewed changes

Comment thread acl/tests/kola_enforcing.yaml

mayankfz changed the title ~~add exception to acl.kdump for qemu + aarch64~~ add exception to acl.kdump and acl.kdump.grub for qemu + aarch64 Sep 7, 2026

Uh oh!

Conversation

mayankfz commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Log

Type of Change

Does this affect the image build?

Associated Issues

Merge Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Jiri Appl (jiria) Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

mayankfz Aug 8, 2026

Choose a reason for hiding this comment

Uh oh!

Jiri Appl (jiria) Aug 8, 2026

Choose a reason for hiding this comment

Uh oh!

mayankfz Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

Jiri Appl (jiria) commented Aug 7, 2026

Uh oh!

Jiri Appl (jiria) commented Aug 8, 2026

Uh oh!

mayankfz commented Aug 8, 2026

Uh oh!

mayankfz commented Aug 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

SeanDougherty Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mayankfz commented Jul 10, 2026 •

edited

Loading