kola/kubeadm: fix etcd MCR override to use ETCD_IMAGE_URL - #24
Draft
Jiri Appl (jiria) wants to merge 1 commit into
Draft
kola/kubeadm: fix etcd MCR override to use ETCD_IMAGE_URL#24Jiri Appl (jiria) wants to merge 1 commit into
Jiri Appl (jiria) wants to merge 1 commit into
Conversation
The prior drop-in set Environment=ETCD_IMAGE, but the flatcar etcd-wrapper builds the image reference from ETCD_IMAGE_URL (default quay.io/coreos/etcd) and ETCD_IMAGE_TAG (set to v3.5.22 by the CLCT etcd drop-in). ETCD_IMAGE is not read by the wrapper, so the override had no effect: the etcd node kept pulling quay.io/coreos/etcd:v3.5.22, which is blocked by the Azure kola pool egress restriction, so etcd never became healthy and every kubeadm.* test failed at the pre-kubeadm etcd health poll. Override ETCD_IMAGE_URL=mcr.microsoft.com/oss/v2/etcd-io/etcd instead; combined with the transpiler-set ETCD_IMAGE_TAG=v3.5.22 this yields mcr.microsoft.com/oss/v2/etcd-io/etcd:v3.5.22, which exists on MCR and is reachable from the Azure pool. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the systemic kubeadm kola failure on ACL Azure (build 1156311) where every
kubeadm.*test fails at the pre-kubeadm etcd health poll with:kubeadm.go:239: unable to setup cluster: unable to get etcd node health: health polling failed: Process exited with status 1Root cause
The prior commit (6a75c39) added an
etcd-member.servicedrop-in that setEnvironment="ETCD_IMAGE=mcr.microsoft.com/oss/v2/etcd-io/etcd:v3.5.22"to move the etcd image pull from quay.io (egress-blocked on the Azure kola pool) to MCR.However the flatcar etcd-wrapper builds the image reference from
ETCD_IMAGE_URL(defaultquay.io/coreos/etcd) +ETCD_IMAGE_TAG(set tov3.5.22by the CLCT etcd drop-in20-clct-etcd-member.conf). A combinedETCD_IMAGEvariable is not read by the wrapper, so the override had no effect — the etcd node kept pullingquay.io/coreos/etcd:v3.5.22, the blocked pull failed, etcd never became healthy, and every kubeadm test failed identically to before the "fix".Fix
Override
ETCD_IMAGE_URL=mcr.microsoft.com/oss/v2/etcd-io/etcdinstead. Combined with the transpiler-setETCD_IMAGE_TAG=v3.5.22this resolves tomcr.microsoft.com/oss/v2/etcd-io/etcd:v3.5.22— verified to exist on MCR (/v2/oss/v2/etcd-io/etcd/tags/listincludesv3.5.22) and reachable from the Azure pool.Testing
GOOS=linux go build ./kola/tests/kubeadm/passes.