etcd: use version 3.5.16 in ACL fixtures - #36
Merged
Conversation
MCR v2 does not publish etcd 3.5.0. Use 3.5.16 for the discovery and Flannel fixtures so ACL tests exercise a supported multi-architecture image.
6 tasks
Garrett Settles (gsettles01)
marked this pull request as ready for review
August 31, 2026 22:44
Copilot started reviewing on behalf of
Garrett Settles (gsettles01)
August 31, 2026 22:45
View session
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned etcd version used by ACL-related kola test fixtures from 3.5.0 to 3.5.16, aligning with ACL defaults and ensuring the pinned version is available for both amd64 and arm64.
Changes:
- Bump the shared Flannel test fixture etcd version to
3.5.16. - Bump the v2 backup/restore fixture etcd version to
3.5.16.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kola/tests/flannel/flannel.go | Updates the embedded etcd config used by Flannel tests to pin etcd 3.5.16. |
| kola/tests/etcd/discovery.go | Updates the v2 backup/restore fixture’s embedded etcd config to pin etcd 3.5.16. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jiri Appl (jiria)
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the v2 backup/restore and Flannel etcd pins from
3.5.0to3.5.16. MCR v2 lacks3.5.0, while3.5.16matches ACL's default and supports AMD64 and ARM64. Other test configuration is unchanged.Change Log
kola/tests/etcd/discovery.go.kola/tests/flannel/flannel.go.Type of Change
Associated Issues
Related PRs
Test Methodology
Merge Checklist