Skip to content

AlliedVisionCamera: start seq acq in correct order #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marktsuchida merged 1 commit into from
Jun 24, 2026
Merged

AlliedVisionCamera: start seq acq in correct order #963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions DeviceAdapters/AlliedVisionCamera/AlliedVisionCamera.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,26 +1276,12 @@ int AlliedVisionCamera::StartSequenceAcquisition(long numImages, double interval
m_frames[i].context[0] = this; //<! Pointer to camera
m_frames[i].context[1] = reinterpret_cast<void *>(i); //<! Pointer to frame index

auto frameCallback = [](const VmbHandle_t cameraHandle, const VmbHandle_t streamHandle, VmbFrame_t *frame)
{
(void)cameraHandle;
(void)streamHandle;
reinterpret_cast<AlliedVisionCamera *>(frame->context[0])->insertFrame(frame);
};

err = m_sdk->VmbFrameAnnounce_t(m_handle, &(m_frames[i]), sizeof(VmbFrame_t));
if (err != VmbErrorSuccess)
{
LOG_ERROR(err, "Error during frame praparation for continous acquisition!");
return err;
}

err = m_sdk->VmbCaptureFrameQueue_t(m_handle, &(m_frames[i]), frameCallback);
if (err != VmbErrorSuccess)
{
LOG_ERROR(err, "Error during frame praparation for continous acquisition!");
return err;
}
}

err = m_sdk->VmbCaptureStart_t(m_handle);
Expand All @@ -1305,9 +1291,28 @@ int AlliedVisionCamera::StartSequenceAcquisition(long numImages, double interval
return err;
}

err = m_sdk->VmbFeatureCommandRun_t(m_handle, g_AcquisitionStart);
auto frameCallback = [](const VmbHandle_t cameraHandle, const VmbHandle_t streamHandle, VmbFrame_t *frame)
{
(void)cameraHandle;
(void)streamHandle;
reinterpret_cast<AlliedVisionCamera *>(frame->context[0])->insertFrame(frame);
};

for (size_t i = 0; i < MAX_FRAMES; i++)
{
err = m_sdk->VmbCaptureFrameQueue_t(m_handle, &(m_frames[i]), frameCallback);
if (err != VmbErrorSuccess)
{
LOG_ERROR(err, "Error during frame praparation for continous acquisition!");
return err;
}
}

// Set the flag before AcquisitionStart so frame callbacks that fire
// immediately can re-queue their buffers (insertFrame requires IsCapturing).
m_isAcquisitionRunning = true;

err = m_sdk->VmbFeatureCommandRun_t(m_handle, g_AcquisitionStart);
if (err != VmbErrorSuccess)
{
LOG_ERROR(err, "Error during start acquisition!");
Expand Down
Loading