AlliedVisionCamera: start seq acq in correct order#963
Merged
marktsuchida merged 1 commit intoJun 24, 2026
Merged
Conversation
Queue the frame buffers after starting the capture, not before, as the documentation says to do. This matches the snap implementation, which works correctly. (Also: avoid potentially blocking requeuing of frames when acquisition has just started: set m_isAcquisitionRunning before starting acquisition.) (Assisted by Claude Code; any errors are mine.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #961.
Queue the frame buffers after starting the capture, not before, as the documentation says to do. This matches the snap implementation, which works correctly.
(Also: avoid potentially blocking requeuing of frames when acquisition has just started: set m_isAcquisitionRunning before starting acquisition.)