refactor(sim): reuse PR33 link-budget helpers#77
Conversation
a36b7bc to
db3debf
Compare
b495d48 to
3f9a5af
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f9a5afe9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3f9a5af to
6fed8ee
Compare
6fed8ee to
4fb0fd3
Compare
4fb0fd3 to
0ce6eaf
Compare
0ce6eaf to
0a25ca3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a25ca3d8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
This is the small reusable optimization slice from the stale #33 after the work was split along the discussion in #39 and #50.
The new review surface on top of #72 is intentionally narrow:
estimate_path_loss()can take an explicit path-lossmodel=without mutatingConfig.MODEL, so scenario or analysis code can compare models without leaking global config stateMeshPacketrecords the receiver IDs it already classified as CAD-detected or sensitivity-sensed while refreshing link budgetsMeshNode.transmit()reuses those receiver-ID lists instead of scanning every node again for flags that were just computedStack context
GitHub shows the full stacked diff against
masteruntil the lower PRs merge. The dependency stack below this PR is #68, #69, #70, #73, #74, #75, #71, and #72. Those carry the map/terrain/clutter/RF/DCR/DTP pieces; this PR only adds the PR33 helper cleanup needed on top of that stack.Why this shape
The useful part from #33 here was not the whole old branch. Maintainer feedback on #33 asked to separate optimizations from Burning Man-specific code, and #39/#50 asked for smaller reviewable PRs.
What is deliberately left out:
lib/signal.py: Sync modem presets with current firmware #33 adds it, but the old branch does not import or call it from the simulator path, so reviving it here would add dead API surface without a callerburningManSim.py: kept out of this PR because it is scenario-specific and depends on the newer DCR/DTP/radio-policy stack; that belongs in the separate feat(sim): add Burning Man DCR/DTP scenario #78 scenario PRValidation
MPLBACKEND=Agg .venv/bin/python -m unittest tests.test_phy tests.test_lora_mesh_cli tests.test_node tests.test_dtp tests.test_packet -v-> 58 tests OKgit diff --check origin/pr/72..origin/pr/77unittestcheck is green