Skip to content

refactor(sim): reuse PR33 link-budget helpers#77

Draft
Komzpa wants to merge 24 commits into
meshtastic:masterfrom
Komzpa:codex/pr33-remaining-optimizations
Draft

refactor(sim): reuse PR33 link-budget helpers#77
Komzpa wants to merge 24 commits into
meshtastic:masterfrom
Komzpa:codex/pr33-remaining-optimizations

Conversation

@Komzpa
Copy link
Copy Markdown
Contributor

@Komzpa Komzpa commented May 5, 2026

Summary

This is the small reusable optimization slice from the stale #33 after the work was split along the discussion in #39 and #50.

The new review surface on top of #72 is intentionally narrow:

  • estimate_path_loss() can take an explicit path-loss model= without mutating Config.MODEL, so scenario or analysis code can compare models without leaking global config state
  • MeshPacket records the receiver IDs it already classified as CAD-detected or sensitivity-sensed while refreshing link budgets
  • MeshNode.transmit() reuses those receiver-ID lists instead of scanning every node again for flags that were just computed

Stack context

GitHub shows the full stacked diff against master until the lower PRs merge. The dependency stack below this PR is #68, #69, #70, #73, #74, #75, #71, and #72. Those carry the map/terrain/clutter/RF/DCR/DTP pieces; this PR only adds the PR33 helper cleanup needed on top of that stack.

Why this shape

The useful part from #33 here was not the whole old branch. Maintainer feedback on #33 asked to separate optimizations from Burning Man-specific code, and #39/#50 asked for smaller reviewable PRs.

What is deliberately left out:

Validation

  • MPLBACKEND=Agg .venv/bin/python -m unittest tests.test_phy tests.test_lora_mesh_cli tests.test_node tests.test_dtp tests.test_packet -v -> 58 tests OK
  • git diff --check origin/pr/72..origin/pr/77
  • GitHub unittest check is green

@Komzpa Komzpa force-pushed the codex/pr33-remaining-optimizations branch from a36b7bc to db3debf Compare May 5, 2026 19:32
@Komzpa Komzpa changed the title perf(sim): split safe PR33 optimizations refactor(sim): split reusable PR33 radio helpers May 5, 2026
@Komzpa Komzpa force-pushed the codex/pr33-remaining-optimizations branch 2 times, most recently from b495d48 to 3f9a5af Compare May 5, 2026 20:17
@Komzpa Komzpa changed the title refactor(sim): split reusable PR33 radio helpers refactor(sim): reuse PR33 link-budget helpers May 5, 2026
@Komzpa Komzpa marked this pull request as ready for review May 5, 2026 20:32
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f9a5afe9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread loraMesh.py Outdated
@Komzpa Komzpa marked this pull request as draft May 6, 2026 06:15
@Komzpa Komzpa force-pushed the codex/pr33-remaining-optimizations branch from 3f9a5af to 6fed8ee Compare May 6, 2026 07:06
@Komzpa Komzpa force-pushed the codex/pr33-remaining-optimizations branch from 6fed8ee to 4fb0fd3 Compare May 14, 2026 11:37
@Komzpa Komzpa force-pushed the codex/pr33-remaining-optimizations branch from 4fb0fd3 to 0ce6eaf Compare May 15, 2026 20:50
@Komzpa Komzpa force-pushed the codex/pr33-remaining-optimizations branch from 0ce6eaf to 0a25ca3 Compare May 15, 2026 21:01
@Komzpa Komzpa marked this pull request as ready for review May 17, 2026 17:24
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a25ca3d8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/packet.py
@Komzpa Komzpa marked this pull request as draft May 17, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant