Sync modem presets with current firmware#33
Draft
powersjcb wants to merge 10 commits into
Draft
Conversation
- Replace array-based modem configuration with preset dictionary - Add missing SHORT_TURBO preset (500kHz, SF=7, CR=5) - Fix coding rates to match firmware (CR=5 for most, CR=8 for LONG_MODERATE/SLOW) - Add current_preset property for cleaner access throughout codebase - Update all references from array indices to string-based preset names - Add Docker support for testing without local environment setup This brings the simulator in sync with the current Meshtastic firmware modem presets and improves maintainability with string-based configuration.
Contributor
Author
|
It looks like the coding rate (CR) was wrong for some of the configs. Modem Preset Configuration Differences
|
Member
|
Looking good @powersjcb, thanks.
True, actually we changed this somewhere in firmware 2.4 I think. It's a non-breaking change as the CR is in the LoRa header, so you can change it on the fly even. |
Member
|
Hey @powersjcb, hope you had a good time at Burning Man. If you have time, could you separate the optimizations from the Burning Man-specific changes so we could get this merged? |
Contributor
|
This PR looks stale, but has a number of changes that look useful for some things I'm wanting to do with Meshtasticator. I can't make any promises, but I'd like to make a PR of just the modem configuration updates, and perhaps other PRs for the other changes. Seem fine? |
Member
|
@zandi yes, I would greatly appreciate that! I guess @powersjcb would be fine with it as well. |
Merged
7 tasks
This was referenced May 5, 2026
Contributor
|
@GUVWAF I've pulled all changes from this into my PRs stack as separate PRs as we had overlaps in code/ideas and it becomes much smaller after these are deduped. See #77 #78. I guess the Burning man part can hang in my / @powersjcb fork until it gets generalized enough to be just sim inputs + vanilla radio stack and we can run it as focused realistic preset scenario in the future, like #73 does for Batumi. If that's ok you can close this one and let's pick changes up at #77 and #78 as deeper part of the merge stack. |
Contributor
|
I've been working on a number of these optimizations for a while and will
be ready to have a PR soon. Also I'm not sure how much of the burning man
sim/other changes are things that are worth bringing into upstream.
At least in my own adaptation of these changes so far, the time savings for
a default config 30-node sim is very small. 30 seconds rather than 30.5
seconds, for example.
…On Wed, May 6, 2026, 2:22 AM Darafei Praliaskouski ***@***.***> wrote:
*Komzpa* left a comment (meshtastic/Meshtasticator#33)
<#33 (comment)>
@GUVWAF <https://github.com/GUVWAF> I've pulled all changes from this
into my PRs stack as separate PRs as we had overlaps in code/ideas and it
becomes much smaller after these are deduped. See #77
<#77> #78
<#78>. I guess the
Burning man part can hang in my / @powersjcb
<https://github.com/powersjcb> fork until it gets generalized enough to
be just sim inputs + vanilla radio stack and we can run it as focused
realistic preset scenario in the future, like #73
<#73> does for Batumi.
If that's ok you can close this one and let's pick changes up at #77
<#77> and #78
<#78> as deeper part of
the merge stack.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG3ASSEUFYGXI5UYKFKHSL4ZLK2JAVCNFSM6AAAAACCMPFCJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGOBVGYYDCMBZGY>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Contributor
|
It's close to ready, I think I can have a PR for it in the next day or two
…On Wed, May 6, 2026, 8:26 AM Darafei Praliaskouski ***@***.***> wrote:
*Komzpa* left a comment (meshtastic/Meshtasticator#33)
<#33 (comment)>
@zandi <https://github.com/zandi> please, if you have a branch, bring it
on, I'll be happy if it gets merged before #77
<#77> lands with the
queue before it.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG3ASWTUVJ7XJ5KVMZWJBT4ZMVQTAVCNFSM6AAAAACCMPFCJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGOBXHEYDOMBZGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
zandi
added a commit
to zandi/Meshtasticator
that referenced
this pull request
May 6, 2026
…n MeshNode Just more data we track for later analysis. Not actually used yet, just updated. Mostly because it's in abandoned PR meshtastic#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the simulator in sync with the current Meshtastic firmware modem presets and improves maintainability with string-based configuration.