Skip to content

fix(tests): qualify importer types in unity builds #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aunjgr merged 1 commit into from
Oct 8, 2026
Merged

fix(tests): qualify importer types in unity builds #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions test/c/test_extension_import.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class ImportHandler final : public SubstraitExtensionHandler {
types++;
return LogicalType::BIGINT; // test-only carrier, not numeric execution
}
unique_ptr<ParsedExpression> Literal(ClientContext &, const SubstraitExtensionIdentity &id,
duckdb::unique_ptr<ParsedExpression> Literal(ClientContext &, const SubstraitExtensionIdentity &id,
const substrait::Expression_Literal &literal) const override {
REQUIRE(id.name == "exact");
REQUIRE(literal.user_defined().type_parameters_size() == 3);
Expand All @@ -35,18 +35,18 @@ class ImportHandler final : public SubstraitExtensionHandler {
literals++;
return make_uniq<ConstantExpression>(Value::BIGINT(23));
}
unique_ptr<ParsedExpression> Scalar(ClientContext &, const SubstraitExtensionIdentity &id,
duckdb::unique_ptr<ParsedExpression> Scalar(ClientContext &, const SubstraitExtensionIdentity &id,
const substrait::Expression_ScalarFunction &fn,
vector<unique_ptr<ParsedExpression>> children) const override {
duckdb::vector<duckdb::unique_ptr<ParsedExpression>> children) const override {
REQUIRE(id.name == "identity:complete-signature");
REQUIRE(fn.has_output_type());
REQUIRE(children.size() == 1);
scalars++;
return std::move(children[0]);
}
unique_ptr<ParsedExpression> Aggregate(ClientContext &, const SubstraitExtensionIdentity &id,
duckdb::unique_ptr<ParsedExpression> Aggregate(ClientContext &, const SubstraitExtensionIdentity &id,
const substrait::AggregateFunction &fn,
vector<unique_ptr<ParsedExpression>> children) const override {
duckdb::vector<duckdb::unique_ptr<ParsedExpression>> children) const override {
REQUIRE(id.name == "total:complete-signature");
REQUIRE(fn.has_output_type());
REQUIRE(children.size() == 1);
Expand Down Expand Up @@ -90,13 +90,13 @@ void Parameters(Parameterized *type) {
}
}

unique_ptr<QueryResult> Execute(Connection &con, const substrait::Plan &plan,
shared_ptr<SubstraitExtensionHandler> handler) {
duckdb::unique_ptr<QueryResult> Execute(Connection &con, const substrait::Plan &plan,
duckdb::shared_ptr<SubstraitExtensionHandler> handler) {
SubstraitToDuckDB converter(con.context, plan.SerializeAsString(), false, false, std::move(handler));
return converter.TransformPlan()->Execute();
}

void CheckValue(unique_ptr<QueryResult> result, int64_t expected) {
void CheckValue(duckdb::unique_ptr<QueryResult> result, int64_t expected) {
REQUIRE_FALSE(result->HasError());
auto chunk = result->Fetch();
REQUIRE(chunk);
Expand Down
Loading