Repository navigation
fix(tests): qualify importer types in unity builds - #4
Merged
aunjgr merged 1 commit intoOct 8, 2026
Conversation
aunjgr
marked this pull request as ready for review
October 8, 2026 02:33
4 tasks done
aunjgr
merged commit Oct 8, 2026
95d9ce8
into
matrixorigin:feature/26155-substrait-anti-joins
2 of 3 checks passed
1 task done
This was referenced Oct 8, 2026
zuyu
pushed a commit
that referenced
this pull request
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C unit-test unity build imports both
stdandduckdbfrom neighboring test sources. This makes the new extension-import test's unqualified pointer and vector names ambiguous and fails compilation in #3.Qualify the DuckDB types explicitly. Existing test scenarios and assertions are preserved; production importer behavior is unchanged.
Validation: reproduced the original failure using the five-source unity translation unit with Sirius's pinned DuckDB and frozen
moPixi toolchain, then verified the fixed unity unit compiles. The linked independent C++ consumer passes all 60 assertions.git diff --checkpasses. macOS CI remains a separate check.Targets the compatible
feature/26155-substrait-anti-joinsbranch, merged #3 atdd4cab14b82754ca919633913436cd530f496e00. Refs matrixorigin/matrixone#28968 and matrixorigin/matrixone#28966.