Repository navigation
fix(P0 installer): guard interrupted VB-CABLE install against destructive rerun - #844
Conversation
Guard uncertain UAC/vendor outcomes and damaged status records so later interactive upgrades cannot invoke the vendor REMOVE action. Preserve auto-install for genuinely missing devices, skip healthy installs, and add Windows detection fixture coverage.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…prior state Keep old PENDING_REBOOT behavior asserted by the source contract, and treat valid JSON lacking a recognized state as an uncertain previous attempt instead of a fresh install.
Deploying arsonmix with
|
| Latest commit: |
d5af909
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b2f4ff6b.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-p0-vbcable-interrupted-i.arsonmix.pages.dev |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
/arsonmix-ci fat 50f1a67 |
Laporan P0 installer VB-CABLE — exact-SHAProduk: Otomatisasi tanpa checkbox dari #843 tetap dipertahankan. Existing VB-CABLE yang sehat dilewati. Jika instalasi vendor sebelumnya terinterupsi (AWAITING_UAC), status tidak dikenal/rusak, atau vendor return nonzero, setup berikutnya menolak mengulang vendor installer yang mungkin berubah menjadi REMOVE. REPAIR_REQUIRED hanya recovery manual. Tidak ada perubahan PCM/ASIO/GUI/session. SHA: 50f1a67 CI final SHA: Fast native PASS; Inno smoke PASS; vendor archive PASS; dispatch/contracts PASS. Kegagalan tes pada commit pertama karena expected token lama sudah diperbaiki. Pengguna: TIDAK PERLU MELAKUKAN APA-APA untuk perubahan kode. Installer terverifikasi PR #843 (run 44803461570) tersedia tetapi belum mengandung tambahan pengaman PR #844. |
Record unrecoverable handoff failures as REPAIR_REQUIRED, not automatic retry; recognize healthy already-installed cable despite corrupted previous JSON; exercise real script control flow with offline synthetic signed-fixture handoff and rerun guards. No actual driver execution in CI.
|
/arsonmix-ci fat d5af909 |
P0 user-visible smart VB-CABLE installer — ready for exact-SHA FAT
Preserves the no-checkbox automatic VB-CABLE preflight introduced by #843. Existing healthy VB-CABLE devices are skipped and the mixer still launches. Missing devices trigger only the pinned-SHA256 / Authenticode-verified official vendor setup; no UAC bypass, no default speaker change, no driver removal, no automatic audio output arm.
Reliability hardening / real bug fixed
Start-Process -Verb RunAshandoff may throw after the vendor process has launched. From handoff onward, errors are REPAIR_REQUIRED rather than retryable FAILED. This closes the uncertain ShellExecute gap.Deterministic Windows regression
Exact delivery receipt
d5af909a18bb3a346104fe0bf1e663739ab0312e40270f0db05f2b984a21a90d937c6bc0899901ad50f1a67(run 44812462326) PASS 108/108 native CTest + installer, upgrade and rollback, but does not contain the new handoff fixes.d5af909arequested/run 44819179328, currently in progress. Review service quota prevents automatic Codex review; this is not a clean review result. Unrelated PR Pages check is non-required and not proof of native failure.Protected invariants
One accepted native ASIO PCM/FX render graph, no second render owner, no automatic output arm, one approved /preview/, .smix preservation, no unchecked vendor package, no silent UAC circumvention.