Skip to content

fix(P0 installer): guard interrupted VB-CABLE install against destructive rerun - #844

Merged
masarray merged 5 commits into
mainfrom
fix/p0-vbcable-interrupted-installer-guard-20261121
Nov 20, 2026
Merged

masarray merged 5 commits into
mainfrom
fix/p0-vbcable-interrupted-installer-guard-20261121

Conversation

@masarray

@masarray masarray commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

P0 user-visible smart VB-CABLE installer — ready for exact-SHA FAT

Preserves the no-checkbox automatic VB-CABLE preflight introduced by #843. Existing healthy VB-CABLE devices are skipped and the mixer still launches. Missing devices trigger only the pinned-SHA256 / Authenticode-verified official vendor setup; no UAC bypass, no default speaker change, no driver removal, no automatic audio output arm.

Reliability hardening / real bug fixed

  • An interrupted UAC/vendor setup must not be blindly run again because the official setup can present REMOVE after partial installation.
  • On-disk states AWAITING_UAC, REPAIR_REQUIRED, unknown and invalid JSON fail closed when device is absent.
  • A corrupted previous JSON does not hide a now healthy cable: PnP is checked and the healthy device is recognized, skipping vendor setup.
  • A Start-Process -Verb RunAs handoff may throw after the vendor process has launched. From handoff onward, errors are REPAIR_REQUIRED rather than retryable FAILED. This closes the uncertain ShellExecute gap.
  • Healthy, pending reboot and failed-prelaunch cases remain separate; vendor process never retries automatically after uncertain attempt.

Deterministic Windows regression

  • Existing PnP / reboot / unhealthy / missing tests retained.
  • Added corrupt-status-but-healthy, empty-status JSON, interrupted UAC and synthetic vendor ZIP fixture with a mocked Authenticode certificate and Start-Process failure (no real driver executed), including a second-run no-launch assertion.
  • Installer source and Node contracts updated; no core mixer/PCM/FX/ASIO or /preview/ code changed.

Exact delivery receipt

  • HEAD: d5af909a18bb3a346104fe0bf1e663739ab0312e
  • Main baseline at PR creation: 40270f0db05f2b984a21a90d937c6bc0899901ad
  • Fast native contracts: PASS. Inno Windows smoke: PASS. Official vendor archive verification: PASS. Required CI Merge Gate: SUCCESS.
  • Earlier exact-SHA FAT 50f1a67 (run 44812462326) PASS 108/108 native CTest + installer, upgrade and rollback, but does not contain the new handoff fixes.
  • New exact-SHA FAT d5af909a requested/run 44819179328, currently in progress. Review service quota prevents automatic Codex review; this is not a clean review result. Unrelated PR Pages check is non-required and not proof of native failure.
  • No hardware Windows 10 clean VM / physical VB-CABLE UAC / ASIO two-vendor validation claimed. Merge status OPEN until actual validation and protected policy permit.

Protected invariants

One accepted native ASIO PCM/FX render graph, no second render owner, no automatic output arm, one approved /preview/, .smix preservation, no unchecked vendor package, no silent UAC circumvention.

Guard uncertain UAC/vendor outcomes and damaged status records so later interactive upgrades cannot invoke the vendor REMOVE action. Preserve auto-install for genuinely missing devices, skip healthy installs, and add Windows detection fixture coverage.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-20T20:32:18.290906Z
We couldn’t complete this review. Comment @codex review to try again.
50f1a67 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

…prior state

Keep old PENDING_REBOOT behavior asserted by the source contract, and treat valid JSON lacking a recognized state as an uncertain previous attempt instead of a fresh install.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: d5af909
Status: ✅  Deploy successful!
Preview URL: https://b2f4ff6b.arsonmix.pages.dev
Branch Preview URL: https://fix-p0-vbcable-interrupted-i.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 50f1a67

Copy link
Copy Markdown
Owner Author

Laporan P0 installer VB-CABLE — exact-SHA

Produk: Otomatisasi tanpa checkbox dari #843 tetap dipertahankan. Existing VB-CABLE yang sehat dilewati. Jika instalasi vendor sebelumnya terinterupsi (AWAITING_UAC), status tidak dikenal/rusak, atau vendor return nonzero, setup berikutnya menolak mengulang vendor installer yang mungkin berubah menjadi REMOVE. REPAIR_REQUIRED hanya recovery manual. Tidak ada perubahan PCM/ASIO/GUI/session.

SHA: 50f1a67
Branch: fix/p0-vbcable-interrupted-installer-guard-20261121
Files: installer/ArSonMixVBCableInstall.ps1; scripts/test_inno_graceful_update_windows.ps1; tests/windows_installer_contract_test.mjs

CI final SHA: Fast native PASS; Inno smoke PASS; vendor archive PASS; dispatch/contracts PASS. Kegagalan tes pada commit pertama karena expected token lama sudah diperbaiki.
FAT Windows exact SHA: run 44812462326 IN PROGRESS, installer #844 BELUM tersedia sampai artifacts terverifikasi.
Review Codex: blocked because quota/usage limit (not PASS). Merge: OPEN, NOT MERGED. Windows 10 clean VM + physical ASIO/driver FAT: NOT RUN.

Pengguna: TIDAK PERLU MELAKUKAN APA-APA untuk perubahan kode. Installer terverifikasi PR #843 (run 44803461570) tersedia tetapi belum mengandung tambahan pengaman PR #844.
Langkah berikutnya: FAT artifacts dan protected gate/review, lalu merge hanya jika seluruh syarat benar-benar terpenuhi. Jangan melanggar satu GUI /preview/, satu render graph, dan larangan auto-ARM output.

Record unrecoverable handoff failures as REPAIR_REQUIRED, not automatic retry; recognize healthy already-installed cable despite corrupted previous JSON; exercise real script control flow with offline synthetic signed-fixture handoff and rerun guards. No actual driver execution in CI.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat d5af909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant