Repository navigation
fix(P0 Win10 startup): automatic signed WebView2 prerequisite, preserve static VC runtime - #845
Conversation
… guarded bootstrapper
…nd GUI Ship the signed Microsoft Evergreen bootstrap helper in the Windows installer, execute only for interactive installs when WebView2 is missing, record diagnostics, preserve static MSVC CRT, VB-CABLE and existing audio configuration. Add deterministic Node and native Windows PowerShell policy contracts.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
/arsonmix-ci fat 4ac7e80 |
Deploying arsonmix with
|
| Latest commit: |
4ac7e80
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f6778b3.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-p0-win10-webview2-smart.arsonmix.pages.dev |
Completed P0 startup / installer reliability milestoneMERGED MAIN PR #845 at CI proof: exact-SHA FAT Windows #44823809150 SUCCESS: 108/108 CTest, WIN10_STATIC_CRT_PE_PASS, runner build 20348 GUI_READY_NO_AUDIO, first Inno installation, running-app graceful upgrade, uninstall, authentic historical-release upgrade and rollback, user files retained, artifact checksum/handoff verified. Fast native and Inno smoke PASS, Required Merge Gate SUCCESS. Download (GitHub Actions): Windows Installer Preview / FAT portable package. Both artifacts unexpired at final check. No public release has been promoted from this merge; alpha.27 is older. Remaining FIELD FAT: Windows 10 x64 clean VM with WebView2 absent, offline/restricted Win10 case, third-party VST3 startup recovery and physical ASIO routing are NOT RUN. A green Windows Server runner does not prove those scenarios. Target is user test, not production/live-performance certification. |
P0 — Make ArSonMix start on clean Windows 10/11 x64 without asking nontechnical users to hunt for prerequisites
Source diagnosis (audited on main)
Implemented user flow
/silent /installswitches. Verify installed registration and physical executable afterwards.NEEDS_ATTENTION, no fake success, retains native GUI's actionable WebView2 error and the existing Start-menu diagnostics. No loops, untrusted mirror downloads, UAC bypass, system-wide VC++ changes, device/output remap or deletion of .smix.ArSonMix.exesingle launch remain.Scope
New:
installer/ArSonMixWebView2Prerequisite.ps1. Revised:installer/ArSonMix.iss,installer/ArSonMixStartupDiagnostics.ps1,tests/windows_installer_contract_test.mjs,scripts/test_inno_graceful_update_windows.ps1.Engine, JUCE, audio callback, GUI
/preview/, VST3, ASIO and .smix untouched.Validation and support policy
Fast native and Windows Inno smoke are required before FAT. Windows 10 clean-VM actual WebView2 installation/network/offline policy matrix is NOT RUN until separately exercised. Protected status gate is required for merge. Win7 is unsupported: WebView2 109 was last supported and modern JUCE 8 requires Win10. 32-bit needs independent x86 app+VST3+ASIO qualification and is not claimed. Static PE does not prove external vendor plugin runtimes.
Base
mainSHA6c373b9303cc390798af5f84adaba76e6000ce0c(PR #844 merged). Source candidate4ac7e809c3ef931725fabb5a2ff5c9751db6deed.