Skip to content

fix(P0 Win10 startup): automatic signed WebView2 prerequisite, preserve static VC runtime - #845

Merged
masarray merged 2 commits into
mainfrom
fix/p0-win10-webview2-smart-bootstrap-20261121
Nov 20, 2026
Merged

masarray merged 2 commits into
mainfrom
fix/p0-win10-webview2-smart-bootstrap-20261121

Conversation

@masarray

Copy link
Copy Markdown
Owner

P0 — Make ArSonMix start on clean Windows 10/11 x64 without asking nontechnical users to hunt for prerequisites

Source diagnosis (audited on main)

  • Native JUCE /MT is the static MSVC runtime. The exact-PE verifier rejects VCRUNTIME, MSVCP, UCRTBASE(D) and WebView2Loader DLL dependencies; DO NOT install VC++ Redistributable blindly for the host EXE. Differentiate third-party VST3/load errors and old EXE releases from the actual tested host.
  • WebView2 loader is embedded, but the Evergreen runtime is external; native WebView2 GUI preflight already distinguishes missing runtime from successful JS GUI_READY. Previous interactive installer checked VB-CABLE but not WebView2.
  • Existing startup-failure log, safe separate WebView2 profile, wave-shell identity/crash guard, repair updater, self-diagnostic desktop launcher and early GUI_READY handshake retained. No proof of clean Windows 10 hardware FAT yet.

Implemented user flow

  • On interactive Inno setup, check registered WebView2 Evergreen runtime AND its physical versioned binary first; a healthy runtime is skipped (no download/install).
  • Only when missing: download Microsoft's Evergreen bootstrapper from the canonical Microsoft go.microsoft.com redirect, enforce HTTPS/approved final microsoft.com domain, 16 MiB transfer cap, Windows trusted Microsoft Corporation Authenticode and official /silent /install switches. Verify installed registration and physical executable afterwards.
  • Failure (offline/network, policy, incomplete install) records NEEDS_ATTENTION, no fake success, retains native GUI's actionable WebView2 error and the existing Start-menu diagnostics. No loops, untrusted mirror downloads, UAC bypass, system-wide VC++ changes, device/output remap or deletion of .smix.
  • Silent upgrades / enterprise installs skip all runtime downloads and must not open audio in Session 0. Existing VB-CABLE safe auto detection and ArSonMix.exe single launch remain.
  • Runtime diagnostics report appended into existing Windows startup report; audited installer/smoke x64 only.

Scope

New: installer/ArSonMixWebView2Prerequisite.ps1. Revised: installer/ArSonMix.iss, installer/ArSonMixStartupDiagnostics.ps1, tests/windows_installer_contract_test.mjs, scripts/test_inno_graceful_update_windows.ps1.
Engine, JUCE, audio callback, GUI /preview/, VST3, ASIO and .smix untouched.

Validation and support policy

Fast native and Windows Inno smoke are required before FAT. Windows 10 clean-VM actual WebView2 installation/network/offline policy matrix is NOT RUN until separately exercised. Protected status gate is required for merge. Win7 is unsupported: WebView2 109 was last supported and modern JUCE 8 requires Win10. 32-bit needs independent x86 app+VST3+ASIO qualification and is not claimed. Static PE does not prove external vendor plugin runtimes.

Base main SHA 6c373b9303cc390798af5f84adaba76e6000ce0c (PR #844 merged). Source candidate 4ac7e809c3ef931725fabb5a2ff5c9751db6deed.

…nd GUI

Ship the signed Microsoft Evergreen bootstrap helper in the Windows installer, execute only for interactive installs when WebView2 is missing, record diagnostics, preserve static MSVC CRT, VB-CABLE and existing audio configuration. Add deterministic Node and native Windows PowerShell policy contracts.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-20T21:47:45.237100Z
We couldn’t complete this review. Comment @codex review to try again.
4ac7e80 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 4ac7e80

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ac7e80
Status: ✅  Deploy successful!
Preview URL: https://4f6778b3.arsonmix.pages.dev
Branch Preview URL: https://fix-p0-win10-webview2-smart.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

Completed P0 startup / installer reliability milestone

MERGED MAIN PR #845 at 9c5bcdffc297d7fa5375b6edcbca1fd2dbdd54d3 (source artifact HEAD 4ac7e809c3ef931725fabb5a2ff5c9751db6deed). Implemented smart interactive WebView2 Evergreen prerequisite: skip healthy runtime, fetch Microsoft's official Authenticode-verified bootstrapper only if absent, verify installed registration, record diagnostic on failure. No blanket VCRUNTIME installer: primary EXE is /MT static. Preserve no-checkbox VB-CABLE guard #844 and ArSonMix.exe single approved /preview/ GUI; no native PCM/FX/ASIO/.smix modifications.

CI proof: exact-SHA FAT Windows #44823809150 SUCCESS: 108/108 CTest, WIN10_STATIC_CRT_PE_PASS, runner build 20348 GUI_READY_NO_AUDIO, first Inno installation, running-app graceful upgrade, uninstall, authentic historical-release upgrade and rollback, user files retained, artifact checksum/handoff verified. Fast native and Inno smoke PASS, Required Merge Gate SUCCESS.

Download (GitHub Actions): Windows Installer Preview / FAT portable package. Both artifacts unexpired at final check. No public release has been promoted from this merge; alpha.27 is older.

Remaining FIELD FAT: Windows 10 x64 clean VM with WebView2 absent, offline/restricted Win10 case, third-party VST3 startup recovery and physical ASIO routing are NOT RUN. A green Windows Server runner does not prove those scenarios. Target is user test, not production/live-performance certification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant