Skip to content

fix(installer): restore automatic VB-CABLE detection - #843

Merged
masarray merged 2 commits into
mainfrom
fix/windows-vbcable-auto-detect
Nov 20, 2026
Merged

masarray merged 2 commits into
mainfrom
fix/windows-vbcable-auto-detect

Conversation

@masarray

Copy link
Copy Markdown
Owner

Restore the pre-#841 automatic VB-CABLE check on interactive Setup. Installed, offline or reboot-pending devices never reach the vendor executable. If VB-CABLE is absent, the original pinned ZIP and Authenticode checks precede the vendor installer and Windows consent.

The ArSonMix run entry is independent of the driver result. Setup omits Additional Tasks and ignores queued driver files for its own reboot flow. Silent upgrades retain their noninteractive path.

  • Local installer source contracts: 28/28.
  • Windows Inno smoke exercises detection with fake PnP readback and verifies real installer upgrade.
  • Qualify one exact-SHA FAT package for the owner. Clean Windows 10 and physical driver installation remain field checks.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: d92119c
Status: ✅  Deploy successful!
Preview URL: https://1ea64ddb.arsonmix.pages.dev
Branch Preview URL: https://fix-windows-vbcable-auto-det.arsonmix.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T19:34:48.443337Z d92119c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat d92119c

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: d92119cd63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masarray
masarray merged commit 40270f0 into main Nov 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant