Repository navigation
fix(P0 Windows): startup portability, opt-in VB-CABLE and DAW-style native Audio Setup latency - #841
Conversation
…lls audio drivers
…readback honestly
… readback in milliseconds
…udio or user sessions
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
86142de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2b97af5a.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-p0-win10-startup-audio-s.arsonmix.pages.dev |
… one source-owned JS
|
@codex review Review current exact HEAD |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…on with honest provenance
…known & clock-scope fixtures
… premature fatal quit
|
/arsonmix-ci fat bd13180 |
|
/arsonmix-ci ui bd13180 |
…runcating helper body
Integration audit — P0 Windows 10 first launch + latency (concrete actionable gates)Repo snapshot Good changes on PR #841: coherent static CRT intent with binary imports test, optional unchecked VB-CABLE install, early WebView2 actionable dialog+diagnostic, accepted-driver reported IN/OUT frames with buffer and host FX processing readback. These are evidence-backed portability risks; the user's reports have NO precise OS build, Event Viewer/WER code or exact binary source, so no proven diagnosis for every Windows 10 user. Unclosed product gates:
Release: NO new user-facing installer claim until PR #841 exact-head Windows CI, protected merge and artifact provenance pass; then link actual installer. Hardware Win10 launch FAT and electrical loopback latency remain NOT RUN. Please document remaining gaps and owner-safe follow-up. |
Integrate PERF-1 health evidence from PR #840. Preserve an explicit and device-scoped calibration path in the verified primary audio callback, and drive the installer smoke test through the existing GUI-only probe.
|
@codex review |
|
@codex review |
|
/arsonmix-ci fat 3bb29f7 |
|
/arsonmix-ci ui 3bb29f7 |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
/arsonmix-ci ui 86142de |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
/arsonmix-ci fat 86142de |
|
P0 Windows Startup + Audio I/O sudah merged ke main di PASS pada SHA paket: Windows FAT (MSVC, 108/108 CTest, PE import/delay-import, GUI installed WebView2 tanpa audio di build 20348, clean-install/upgrade/uninstall, rollback dua rilis historis) dan Chromium. Audio I/O menampilkan driver IN/OUT, buffer, FX/PDC, dan estimasi total. Kalibrasi kabel direct ASIO terpisah dari estimasi dan sudah diuji dengan PCM sintetis. Profiling #840 masuk ke perubahan ini. NOT RUN: clean Windows 10 x64 VM, kabel loopback ASIO fisik, rollback kandidat ke rilis sebelumnya, dan benchmark perangkat/FX/VST3 fisik. #842 tetap terbuka untuk kualifikasi lapangan dan rilis publik. |
P0 field complaint / INT-1 #837
Many users report ArSonMix installed but will not launch, notably on Windows 10. No WER dump, affected OS build or exact release SHA is yet available: do not misrepresent the root cause as proven. Source audit reveals real compatibility and first-launch risks independent of a particular machine:
CMAKE_MSVC_RUNTIME_LIBRARY, allowing default dynamic/MDto silently depend on a globally preinstalled VC++ Redistributable (typically present on GitHub Windows runner, not guaranteed on clean Win10).CanLaunchMixer(). Unrelated virtual-cable installation must not gate the mixer.Actual changes (one product delivery)
add_subdirectory(JUCE), choose a coherent static /MT MSVC CRT by default for both JUCE libs and GUI if no toolchain override. This avoids implicit VC++ Redistributable deployment on supported fresh Windows x64 machines.scripts/verify_win10_pe_runtime.pyindependently inspects actual packaged PE import and delay-import tables;build_verify_windows_installer.ps1now refuses any EXE still importing dynamicvcruntime/msvcp/concrtDLLs.installvbcable_drivertask. Default installation and first launch do not run its privileged installer. Existing restart behavior applies only to users who affirmatively select it. Keep verified one-launch, in-place WM_CLOSE upgrade, Studio backup, and no forced process kill.%LOCALAPPDATA%/ArSonMix/diagnostics/startup-failure.txt. Does not remove local browser data, .smix, vendor FX or install anything silently.ConsoleWindow::currentDeviceSnapshot()projects the existing accepted JUCE driver-reported IN/OUT frames, host FX delay and clock scope. One approvedweb/mixer-io.jsAUDIO SETUP renders compact IN / OUT / FX / buffer ms and an optional I/O driver hint, correctly labeled NOT measured physical round-trip. Unreported or independent clocks result in N/A, never 0-ms pretend latency. Staged/unapplied driver never presented as measured.Qualification/exit
mainis the baseline. PERF-1 #840 remains separate; reconcile CMake/Main changes only once qualified. I/O feat(io2c): primary-clock ASRC-to-ChannelId reader and stable device-map leases #825/feat(io3): typed secondary ASIO capture intent and native B lease/readback #830, Graphic EQ feat(native FX): Graphic EQ 31 with dbx frequencies and supplied SVG faders #835 and Guitar FX draft stay isolated.