Repository navigation
refactor(native N-MOD-17): compensate live Player settings and durable preferences - #810
Conversation
… Player preferences atomically
|
@codex review Review exact HEAD |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
2eba5e7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fd2b89d5.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-nmod17-player-metad.arsonmix.pages.dev |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
N-MOD-17 exact source check — 2026-11-19Draft PR #810 HEAD The coherent N-MOD-17 boundary:
Integration dependency: parent #799 now groups N-MOD-14/15/16 on HEAD Operator report: HASIL = transactional Player control milestone implemented; STATUS = KODE DIBUAT + FAST DIUJI, NOT Windows-qualified/merged; AMAN DIPAKAI = main unaffected, code new BELUM; TINDAKAN USER = TIDAK PERLU; no installer, ASIO physical FAT or release claim. |
0a3e6c2
into
refactor/native-mv14-player-setlist-archive-20261119
N-MOD-17 — Native Player metadata acceptance + compensating durability
Parent: N-MOD-14/15/16 #799 at
529b2986d3cf5a31b03e1d2b73f50a301d61d1de. This draft contains ONLY N-MOD-17's four file changes and must not independently merge to main before the parent is qualified.Behavior and ownership
engine/player/PlayerLiveMetadataCommitPolicy.h: a deterministic control-thread native accept → durable save → restore prior native values on save failure policy. NEXT edits use durable Save alone, with no native or PCM mutation; CURRENT KEY/TEMPO and Cue preserve the existing synchronous native-first operator response. If both archive Save and native rollback fail, the oneConsoleWindow/Player control owner stops its deck safely, clears pending transition, and emits an actionable error rather than leave unsaved playing metadata silently.playerTrackSettings_before confirmed Save. Cue policy still quantizes/validates before touching native, and accepted Cue loop invalidation occurs only after the accepted Save.commitPlayerPreferences. Rejected writes preserve Auto Next, fade, Loop A/B and AutoAdvance state. ExistingcommitPlayerTrackEditand all preference operations share onecommitPlayerMetadatadisk boundary.saveActivePlayerSetandpersistPlayerLibraryin Main, removing duplicated mutable-save logic. No new deck, PCM callback, AudioDeviceManager, runtime graph, GUI, transport or .smix schema. Audio processing remains the single JUCE owner.Regression/evidence
2eba5e72b39382ad8762ea1bd0d5b010167ec5da; code committed on separate dependent branch. Fast Native, Windows JUCE/MSVC CTest and exact-head code review are NOT YET CONFIRMED on this commit. Do not report hardware FAT/installer or main merge. Parent refactor(native N-MOD-14–18): durable Player transactions, library plans and state projection #799 remains under exact-SHA Windows verification and protected merge.Scope boundary: compensation cannot make disk and an external live engine physically atomic. If native restoration fails the caller stops the Player deck to fail closed. Actual ASIO hardware validation remains pending. This change is not a second PCM owner.
Operator handoff: HASIL: safer live KEY/TEMPO/Cue acceptance plus durable preferences and one common Player storage boundary; STATUS KODE DIBUAT on draft; AMAN DIPAKAI? BELUM for the new code (main untouched); TINDAKAN OWNER: TIDAK PERLU; NEXT: fast tests/review, parent protected merge, reconcile this PR to current main, one exact-SHA Windows CTest, then protected merge.