Skip to content

refactor(gui G-MV27): one-shot native control authority and no stale fallback - #811

Merged
masarray merged 5 commits into
mainfrom
refactor/g-mv27-unified-control-command-20261119
Nov 19, 2026
Merged

masarray merged 5 commits into
mainfrom
refactor/g-mv27-unified-control-command-20261119

Conversation

@masarray

Copy link
Copy Markdown
Owner

G-MV27 — one-shot channel control authority in one pure ViewModel

This follows merged G-MV26 PR #809. Native MUTE/SOLO, fader double-click unity, PAN center reset, and the final consumeField branch used separate authority checks. In particular, the final field branch could call generic SET_FADER / SET_PAN after liveScalarReady had already rejected a live control.

Implemented

  • stripVM.controlCommandPlan returns LOGICAL, CHANNEL_ID, M4, MAIN_HOST, or BLOCK based only on exact existing native readback/identity, capability, M4 ordinal, physical MAIN admission or offline workspace/read-only/pending status. No second controller, event bus or accepted JS mixer.
  • One controlCommandRoute / dispatchControlCommand bridge adapter selects the existing native transports for MUTE, SOLO and double-click fader/PAN reset. Removed prior divergent branches. MAIN remains on the verified physical host routingM4Control scalar, not fake ChannelId main fader; offline .smix uses arMixLogicalIntent without audio device or automatic output arm.
  • Denied live field release no longer bypasses failed preflight through generic ChannelId SET_FADER/SET_PAN. Accepted fader/PAN presentation is restored; existing MV-10 30ms streaming scheduler, pointerup flush, ACK/readback, one PCM renderer and /preview/ are unchanged.
  • Regression cases: pure owner matrix / exact uint64 identity, ChannelId MUTE/FADER/PAN, unsupported operation negative controls, verified M4 ordinal and retired M4, offline .smix channel controls, SOF reset priority.

Qualification

Scoped GUI-only source/tests on main@b30a59303ad3aed486a141c96acc42dec00d2caa. Pure selector smoke PASS; repository CI not yet assessed on PR head. Require Fast UI/Native, exact-head Full Chromium /preview/, Codex review and Required Merge Gate before merge. No JUCE C++, CSS, ASIO hardware FAT or Windows installer change. Parallel N-MOD #799/#810 and IO work untouched.

Known baseline issue independent of this PR

The earlier post-merge main UI run #44453976259 reported a hover screenshot-only Stage C CSS parity mismatch despite pre-merge exact-source Chromium success. Its failed job #135324606652 was rerun once to identify transient vs reproducible failure. Do not treat this PR as fixing CSS and do not waive its visual gate.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T04:16:32.910401Z 84e3389 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 84e3389

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 84e3389
Status: ✅  Deploy successful!
Preview URL: https://926aa447.arsonmix.pages.dev
Branch Preview URL: https://refactor-g-mv27-unified-cont.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

GUI MVVM ↔ future multi-device source inventory handoff

Please continue G-MV27's current pure control authority work independently. Multi-device coordination and IO-2 acceptance: #812. Current IO-0 #770 is merged; IO-1 #771 adds separate JUCE ASIO B producer + existing ASRC but is draft/unmerged, not installed ChannelId PCM and not hardware-FAT qualified.

Ownership: G-MV owns web/approved-native-bridge.js, web/approved-channel-strip-view-model.js, associated JS contracts and one existing schema-v6 native transport/read-model. IO may concurrently implement engine/device/* and pure device-qualified source mapping/tests. Do not have IO mutate the native GUI bridge while G-MV owns it; no second JS accepted mixer, device opening in JS or fake ACTIVE/LIVE status.

The future integration API must expose: immutable per-device qualified input pins (B Input1 != A Input1), physical capability/masks and captureGeneration, primaryEpoch, accepted graphRevision, requestId/negative ACK and later matching installed PCM/readback. GUI Source Picker renders verified active/offline/remap states through existing pure ViewModel; source selection is not itself physical PCM proof. Current G-MV can safely preserve this boundary without implementing IO features now.

Exit criteria for eventual GUI slice: SOURCE ONLY meter without unintended MAIN, ChannelId/FX/WIRE routing, unknown/missing B fail silent, .smix offline intent not discarded, exact native /preview/ parity, no extra output auto-arm. Keep G-MV's current exact-head Chromium/required gate separate from IO's native Windows/physical ASIO FAT. Cross-file handoff only once native IO-2 contract is accepted; don't block G-MV until then.

@masarray
masarray merged commit 3fc172d into main Nov 19, 2026
29 checks passed

Copy link
Copy Markdown
Owner Author

G-MV27 final technical handoff — merged to main (2026-11-19)

MERGED MAIN: PR #811 from reviewed exact head 84e338991883d1e9c4cb63d7fedc364602d6060e, GitHub squash merge 3fc172da943352ba2f4952279f53fa9ea3b7f228 (re-fetched main and PR state).

User-visible operator outcome

  • MUTE/SOLO, fader double-click unity and PAN center reset now use one pure Strip ViewModel authority selector instead of 3 disparate branches. The bridge only maps its verdict to the existing native/LOGICAL transport.
  • Denied live fader/PAN field commit no longer sends an unguarded ChannelId intent after the gesture preflight refused the owner.
  • Physical MAIN gain/mute retains guarded native host scalar. LOGICAL_ONLY .smix edits remain writable without physical PCM; stale M4/ChannelId cannot become command permission. SOF selected send intercepts the fader before any standard fader reset.
  • No WebView2/DOM/CSS/PNG layout changes; no JUCE src/Main.cpp, callback, VST3 or hardware output auto-arm edits; N-MOD and IO workstreams untouched.

Changed files

  • web/approved-channel-strip-view-model.js: controlCommandPlan pure LOGICAL/CHANNEL_ID/M4/MAIN_HOST/BLOCK.
  • web/approved-native-bridge.js: one controlCommandRoute and dispatchControlCommand, remove old MUTE/SOLO and fader/PAN reset owner branches, delete raw denied-live-field fallback.
  • tests/approved_scalar_view_model_contract.test.cjs: exact 64-bit ID, authority, supportedOps and read-only/pending matrix.
  • tests/live_fader_held_drag.test.cjs: real bridge event tests for ChannelId, M4, unsupported controls, offline .smix.
  • tests/approved_native_m2_contract.test.cjs: explicit SOF precedence over unified native fader reset.

Qualification

  • Fast UI source/behavior SUCCESS on exact PR head, including G-MV27 regressions, run #44456978758.
  • Fast Native/source contract SUCCESS, #44456978665.
  • Exact-head Full Chromium /preview/ SUCCESS all 109/109 steps zero failures, #44457199319; Stage C original/compiled CSS parity PASS on this run.
  • Codex exact-head review COMPLETED with zero findings, no unresolved threads.
  • Required CI Merge Gate SUCCESS, exact head 84e338991883d1e9c4cb63d7fedc364602d6060e; original gate publisher job rerun only after Full Chromium completed, no bypass.
  • Main push UI #44458609640 and Fast Native #44458609642 were IN PROGRESS at this checkpoint. Do not misreport post-merge Full Chromium as PASS.
  • Windows installer, field ASIO listening, physical speaker latency/FAT: NOT RUN (not a GUI-only milestone requirement).

Separate existing CI baseline issue

Issue #778 documents nondeterministic Stage C screenshot pixel parity: previous G-MV26 main push and one identical-SHA failed-job retry reported mismatches at different hover/default states although the exact source before merge passed. Evidence was added to that issue; do not weaken pixel parity or modify CSS inside G-MV27. This PR full exact-head parity passed; future main push results must be reported separately.

Owner handoff: HASIL one unified native command preflight and no unauthorized fallthrough; STATUS MERGED MAIN; AMAN DIPAKAI as source baseline YA with protected checks, physical ASIO Windows installer BELUM DIUJI; TINDAKAN USER TIDAK PERLU MELAKUKAN APA-APA; NEXT: audit remaining one-shot FX/Device/WIRE presentation decisions for true duplicate authority only, and close CSS flaky test #778 in a standalone CI-only diagnostic/fix. Do not create extra PCM owner or duplicate bridge controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant