Repository navigation
fix(g-mv26): gate physical MAIN control by accepted native PCM authority - #809
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/arsonmix-ci ui aea0f5b |
Deploying arsonmix with
|
| Latest commit: |
07722be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9281b025.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-g-mv26-main-scalar.arsonmix.pages.dev |
|
@codex review |
|
/arsonmix-ci ui 754d05f |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 754d05fb52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
/arsonmix-ci ui 07722be |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
G-MV26 final owner handoff — merged to mainMERGED: PR #809, squash What changed (4 GUI/test files, no native/DSP/installer changes):
Exact-head qualification:
N-MOD isolation: no |
GUI G-MV closure handoff — stop indefinite incrementingThis PR #809 is already MERGED, so this comment is a coordination handoff for the GUI MVVM implementation thread, not a request to reopen or change the merged PR. Owner direction and shared exit contract: #527 (comment) After G-MV26, first audit current main, not outdated pilot ViewModels, and post to #527 a finite map of what still lives in Define one coherent GUI consolidation milestone with acceptance gates: exactly one v6 controller/IPC dispatcher; one native source of truth for LIVE; ChannelId/EdgeId/physical device identity and stale-request fencing; M4 only where still supported; OFFLINE Make small defects part of that bounded milestone unless a safety-critical independent fix truly needs immediate release. Keep GUI-only files separate from Native #799 source. Freeze the final diff; run cheap source tests first and only the required exact-head Chromium/merge gate once the candidate is stable. Do not initiate duplicate builds or merge a red/pending gate. Record which rules were actually removed from the bridge and which adapter functions intentionally remain. Required next report on #527: main SHA, ownership inventory, explicit residual GUI tasks (or justified DONE), number and nature of duplicate policies eliminated, tests with exact run links, and one finite closure criterion. No automatic G-MV27/G-MV28 just to continue a sequence. GUI closure is not full Native modularization or hardware ASIO FAT. |
G-MV26 — Exact native MAIN scalar authority, no stale-M4 shortcut
Root cause from G-MV25 follow-up audit
The physical MAIN fader/MUTE still uses the existing native
routingM4Controlhost-scalar gateway (intentionally: this is not an invented ChannelId SET_FADER). Its previous GUI eligibility expression usedm4Verified() || nativeMasterReady(), howeverm4Verified()inspects legacy M4 diagnostic fields and can remain true when the actual schema-v6mixerSession.authorityhas switched to ChannelId or become unadmitted. Thus a stale legacy flag could authorize a new MAIN gain/mute command even if the current native producer was not admitted. This change fences that at the accepted native read-model.Implementation
stripVM.masterScalarAuthority(snapshot,{m4Verified,graphConnected}): returnsCHANNEL_ID,M4, orUNAVAILABLE, checking the current mixerSession authority, matching device epoch, retained/admitted status, valid MAIN controls and safe numeric native host tokens. M4 specifically requires current admitted M4 routing revision and verified route; ChannelId must have accepted PCM and completed UI graph projection, never the legacy M4 shortcut.sendM4Controltransport preflight. Physical MAIN still uses its original single native event, ACK/readback settlement and one JUCE graph; no new controller, auto-arm, pseudo PCM, DSP, UI/CSS or .smix modification.Qualification
Source committed on dedicated GUI branch; JavaScript syntax parsed. Need fast UI/native checks, then one exact-head Full Chromium
/preview/milestone and required gate before protected merge. Physical Windows ASIO listening/installer FAT not performed. No N-MOD file overlap.