Repository navigation
refactor(native N-MOD-16): durable-first Player setlist metadata edits - #808
Conversation
|
@codex review Review exact N-MOD-16 source HEAD |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
658cbc2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20cdfb1e.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-nmod16-player-setli.arsonmix.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89c76e6c2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Review exact revised N-MOD-16 HEAD |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c054ae3eff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Review EXACT latest head |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
529b298
into
refactor/native-mv14-player-setlist-archive-20261119
N-MOD-16 — durable-first Player setlist transactions (Native control only)
Stacked dependency: N-MOD-14/15 #799, parent exact
c19c34d76d2528bd613cf13f11a2cb4551f8fd6e. This draft must not be merged into main before #799 passes its full exact-head Windows MSVC/CTest, Required Merge Gate, and protected merge. No changes to production main made by this branch.New canonical control-thread edit boundary
src/PlayerSetlistEditTransaction.hstages native setlist metadata and active-track edits against the authoritative live list, validates withPlayerSetlistArchive, and uses the one atomicPlayerSetlistRepositorydurable Save before returning a candidate to the soleConsoleWindow. Invalid state and failed I/O return without mutating Player/setlist/queue/deck.ConsoleWindow::playerEditSetlistnow sends CREATE/SELECT/DELETE/RENAME to the service. Set switching/deleting stops the one deck and activates selection only after Save succeeds. MOVE/REMOVE/UNDO stage song/control pairs and persist first; selection/current/pending indices, queue revisions and undo tokens advance only after the disk accepts the edit.std::map<juce::File, index>; folder merge usesstd::set<juce::File>for O(log n) path duplicate lookup, retaining platform-sensitive JUCE File equality, first valid file selection and the 2,000-song limit. No new worker, media copying/deletion, browser state machine or realtime PCM callback.Explicit limits
Remaining legacy KEY/TEMPO/CUE transport edits and other calls to
persistPlayerLibrary()may still mutate accepted native control state before the archive write; do not claim all Player persistence is transactional or promote any hardware/installer qualification. Native deck/PCM/FX graph, accepted native ACK/readback, .smix and approved /preview/ GUI remain unchanged.Evidence and safety
658cbc2cca0b14eddc61b2f692765702d5059248, four file paths:src/Main.cpp, new transaction header, JUCE CTest, source-contract test.Handoff: HASIL: durable-first Player metadata, song edits and import/relink. STATUS: KODE DIBUAT; Quick CI latest pending; CTest latest NOT RUN; PR is draft. AMAN DIPAKAI: Existing main unaffected; new code BELUM qualified. TINDAKAN USER: TIDAK PERLU APA-APA. NEXT: resolve current review, promote #799 under strict gate, rebase/reconcile this draft to newest main, run one exact-source Windows CTest, protected merge.