Repository navigation
refactor(mv19): admit native device identity before mutating GUI hardware state - #800
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/arsonmix-ci ui 1cadad3 |
Deploying arsonmix with
|
| Latest commit: |
1cadad3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1c56d877.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-mv19-admit-device-b.arsonmix.pages.dev |
MV-19 — Owner-facing completion (2026-11-19 WIB)HASIL: Fail-closed GUI device admission. A rejected/inconsistent native read-model cannot mutate Device Setup, physical input/output presentation, nor retire a valid pending M4 FX edit. M4 eligibility is evaluated against the candidate accepted snapshot; approved /preview/ and single JUCE PCM/VST3 graph are unchanged. STATUS NYATA: MERGED MAIN as squash commit BUKTI exact PR HEAD:
AMAN DIPAKAI: GUI source change merged and qualified by code/Chromium CI; this is not a new Windows installer or physically ASIO-qualified release. Main push workflows were still running at this handoff; no claim of post-merge PASS until completed. HARDWARE FAT: NOT RUN. TINDAKAN ANDA: Tidak perlu melakukan apa-apa. LANGKAH BERIKUTNYA: Audit next MVVM GUI lifecycle-boundary improvement with real regression evidence; preserve single approved CI observation: A manually dispatched |
G-MV GUI MVVM — post-merge handoff for the ongoing GUI workstreamPlease carry the shared Native + GUI architecture audit into the next GUI milestone. #800 MV-19 is already MERGED at the time of this comment; do not reopen/redo its change or treat this as a request to alter the merged PR. What is now fixed by #800: one read-model and physical device identity must be admitted before any hardware-scoped Device Setup/pin label/EXTERNAL OUT/FX lease UI mutation. Preserve fail-closed behavior across malformed/rejected candidate snapshots, same-epoch device swaps, ChannelId versus verified M4 authority and stale/later ACK. Native accepted PCM remains the only UI truth. Next meaningful GUI modularization: audit Required regression: behavioral Node/Chromium testing for admitted vs rejected readback ordering, independent native ACK + installed graph readback, stale device epoch and reused vendor identity, FX/EXTERNAL OUT lease cleanup, SOURCE ONLY/WIRE/BUS/MAIN, fader/PAN and exact VST3 instance identity; keep visual/bundle parity of native WebView2 Cross-thread boundary: #792 and #799 are independent native C++ workstreams currently open. GUI changes must not touch or overwrite their |
MV-19 — Fail-closed hardware-scoped GUI projection
Operator-facing reliability: An inconsistent native read-model or malformed device identity cannot repaint the accepted Audio I/O controls, physical input labels, output status or clear a pending FX edit. Only an admitted candidate goes through the existing device-change/authority fence, then Device Setup reconciliation, physical panel and EXTERNAL OUT presentation.
Code
web/approved-native-bridge.js: evaluate M4 eligibility from the incoming normalized native snapshot, not from the previously painted globalhardware. Defer transient WIRE visual flush,deviceVM.setupReadback,finishDeviceApplyUi,updateHardwarePaneluntil afterselectNativeReadModelandnativeLifecycleLeaseboth succeed and the MV-18 lifecycle fence runs. Keep external-output presentation after cleanup.tests/approved_device_pin_identity_contract.test.cjs: enforce read-model/lease/lifecycle ordering and independent candidate M4 evidence.tests/approved_native_m2_contract.test.cjs: extend actual VM/WebView M4 reconnect integration: inject a schema-valid but rejected read-model candidate through a guarded controller callback; assert no accepted hardware label/pin choice mutation and no premature release of a pending FX request, then verify a valid same-epoch vendor switch still clears the old lease; late ACK and timer remain fenced.No new source of truth, retry loop, native transport, device driver, CSS, /preview/ variant, JUCE, VST3 PCM, .smix or MAIN auto-arm.
Base: main
7c142caacfe359c0c25ddfb376c780c977e9ec4dInitial review HEAD:
1cadad31224275793305526dc9c28a9cd1e32484Qualification: fast UI/native checks and exact-HEAD Chromium UI milestone to be reviewed before merge; physical ASIO FAT NOT RUN. See maintainability epic #527.
Owner handoff: HASIL: bounded fail-closed GUI readback admission; STATUS: KODE DIBUAT, CI BELUM DIKONFIRMASI; AMAN DIPAKAI: current merged main remains unchanged; TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA; NEXT: resolve fast CI, exact-SHA full Chromium, protected merge if qualified.