Repository navigation
refactor(native N-MOD-13): isolate hotkey command use case - #792
Conversation
Deploying arsonmix with
|
| Latest commit: |
c61b94b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3cd2e984.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-mv13-native-hotkey.arsonmix.pages.dev |
|
/arsonmix-ci native c56a2c5 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Please audit exact C++ MV-13 HEAD |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…tration admission Keep single native ACK/control dispatcher, add pure native registration mapping plan and regression coverage; no PCM, device lifecycle or /preview/ rendering changes.
|
/arsonmix-ci native 54acf5b |
|
@codex review Please review exact native MV-13 HEAD |
|
/arsonmix-ci ui 54acf5b |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Checkpoint Native MV-13 (2026-11-19 Asia/Jakarta)Hasil: Commit implementasi: Evidence (same SHA): Fast UI PASS; Fast Native PASS; latest Codex Review completed without findings. Full Chromium UI and Windows MSVC/CTest running at the last read; not yet qualified. Required CI Merge Gate pending; no installer and no hardware ASIO FAT. Parallel integration: GUI MV-17 #797 has since merged, advancing Status owner: KODE DIBUAT dan fast contracts KODE DIUJI; BELUM MERGED; installer/hardware FAT NOT RUN. AMAN DIPAKAI: current |
No overlapping source files. Preserve GUI MV-17 ACK/PCM timeout logic and all native hotkey use-case tests for protected required-check qualification.
|
/arsonmix-ci native 5086bae |
|
/arsonmix-ci ui 5086bae |
|
@codex review Review exact HEAD |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Reconcile without force, retain single native hotkey planner and all latest GUI source/control tests. No PCM graph or DSP changes.
|
/arsonmix-ci native 333b398 |
|
/arsonmix-ci ui 333b398 |
|
@codex review Please review exact HEAD |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
N-MOD native hotkey workstream — cross-thread audit handoffPlease read the shared GUI + Native architecture audit and acceptance rules before further code/merge decisions. This is a coordination note, not an approval to merge or a request to restart previous M1–M6. Live checkpoint at posting: #792 OPEN, HEAD Do next: complete exact-HEAD native MSVC/JUCE CTest and actual required commit-status verification; confirm current CI, no unsupported FAT claims. Preserve Before merge: recheck main SHA, preserve already-merged GUI MV-19 and all previous native service improvements. Coordinate resulting main SHA with #799, so its PlayerSetlistArchive branch can reconcile instead of accidentally overwriting the hotkey changes. Avoid merging or rebasing based on the stale #799 prose claiming this PR was already merged. After this PR: measure real owner/coupling reduction, not the MV milestone number; cross-reference epic #527. Proposed naming: N-MOD for future native milestones (existing PR number/title may stay). |
…e case Source-only reconciliation of disjoint files on top of last Windows MSVC/CTest-qualified native hotkey SHA. No changes to native hotkey blobs; GUI MV-19 remains canonical.
|
/arsonmix-ci native c61b94b |
|
CI dispatch attempt canceled before any Chromium runner was created (GitHub Actions dispatcher run #44409045319; zero jobs). Original operator request, retained for audit:
Superseded by a new exact-SHA UI request after native dispatcher completed. This is a queued-dispatch cancellation, not a failed Chromium qualification. |
|
@codex review Review exact reconciled HEAD |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
/arsonmix-ci ui c61b94b |
|
N-MOD continuation / CI triage (exact-source evidence):
|
N-MOD-13 — final merged checkpoint (2026-11-19 Asia/Jakarta)MERGED MAIN: PR #792 squash commit Bukti: Fast Native PASS, Fast UI PASS, Windows MSVC/realtime CTest #44409083522 SUCCESS, full approved Outcome: Native hotkey use-case planning is now extracted from Next: Integrated Player archive/Cue application policy N-MOD-14 #799 now depends on this merged source and is undergoing its own Windows CTest. |
MV-13 Native C++ — Hotkey registration + command planning boundary (source implemented)
Scope: native maintainability epic #527; separate from GUI MV-17 PR #797. Reconciled with
main@698d76e06920decc66632e4324a0cc218af50870in an explicit two-parent merge commit, preserving merged GUI MV-13 through MV-16.Operator effect and ownership
src/NativeHotkeyCommandPlan.his a control-thread-only pure policy for registration sanitation/admission and hotkey dispatch. Exact decimal ChannelId, immutable native snapshot, role, capability, session, FX insert lease and native revisions remain authoritative.ConsoleWindowkeeps OS hotkey registration/journal, one existing nativeonAction/handleApprovedNativeControldispatcher, VST3 ParamID service, PANIC semantics and emitted ACK/readback. It no longer constructs or decodes persisted hotkey mapping fields inline.Registry::valid; failure to activate session now fails closed rather than continuing toupsert./preview/, CSS, JS GUI MVVM,.smix, hardware I/O, JUCE callback and DSP are not modified.Exact commit and qualification
54acf5b933594300b95e8fda30fa46c9336128e3; base main:698d76e06920decc66632e4324a0cc218af50870.c56a2c5passed a separate Windows native run, but that does NOT qualify this updated commit.No secondary audio authority, event transport, callback or duplicate UI state.
Latest exact-head CI after GUI MV-19 synchronization — c61b94b
333b398e405559d27933f57569571371bc03aad8: Windows MSVC/CTest, Full Chromium, Fast Native/Fast UI, Codex no-findings review.main@b6dfd41393618e81f6518f53545926a6f8c90876without changing native hotkey source blobs, without force-push or new PCM owner. Fast Native/Fast UI PASS at new exact SHA.44410039996without restarting Windows.