Skip to content

refactor(native N-MOD-13): isolate hotkey command use case - #792

Merged
masarray merged 8 commits into
mainfrom
refactor/mv13-native-hotkey-command-usecase-20261118
Nov 18, 2026
Merged

masarray merged 8 commits into
mainfrom
refactor/mv13-native-hotkey-command-usecase-20261118

Conversation

@masarray

@masarray masarray commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

MV-13 Native C++ — Hotkey registration + command planning boundary (source implemented)

Scope: native maintainability epic #527; separate from GUI MV-17 PR #797. Reconciled with main@698d76e06920decc66632e4324a0cc218af50870 in an explicit two-parent merge commit, preserving merged GUI MV-13 through MV-16.

Operator effect and ownership

  • src/NativeHotkeyCommandPlan.h is a control-thread-only pure policy for registration sanitation/admission and hotkey dispatch. Exact decimal ChannelId, immutable native snapshot, role, capability, session, FX insert lease and native revisions remain authoritative.
  • ConsoleWindow keeps OS hotkey registration/journal, one existing native onAction / handleApprovedNativeControl dispatcher, VST3 ParamID service, PANIC semantics and emitted ACK/readback. It no longer constructs or decodes persisted hotkey mapping fields inline.
  • Native session lease replaces any client-supplied sessionId; mapping decode still enforces Registry::valid; failure to activate session now fails closed rather than continuing to upsert.
  • Regression coverage for uint64 IDs, FX slot reorder/replacement, invalid graph/session/role, forged sessionId, malformed registration, APP PANIC and existing native registry persistence.
  • /preview/, CSS, JS GUI MVVM, .smix, hardware I/O, JUCE callback and DSP are not modified.

Exact commit and qualification

  • Current PR HEAD: 54acf5b933594300b95e8fda30fa46c9336128e3; base main: 698d76e06920decc66632e4324a0cc218af50870.
  • Earlier C++ source commit c56a2c5 passed a separate Windows native run, but that does NOT qualify this updated commit.
  • Fast native/UI source contracts and exact SHA gate: running/recheck at current HEAD. One exact-SHA native MSVC + CTest run required before merge. Do not infer physical ASIO or Windows installer verification from tests.
  • Owner-facing: HASIL modular C++ registration+dispatch policy; STATUS KODE DIBUAT, BELUM MERGED; AMAN DIPAKAI not as new installer; TINDAKAN USER TIDAK PERLU MELAKUKAN APA-APA; NEXT exact-HEAD native CTest / review / required status then protected merge.

No secondary audio authority, event transport, callback or duplicate UI state.

Latest exact-head CI after GUI MV-19 synchronization — c61b94b

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: c61b94b
Status: ✅  Deploy successful!
Preview URL: https://3cd2e984.arsonmix.pages.dev
Branch Preview URL: https://refactor-mv13-native-hotkey.arsonmix.pages.dev

View logs

@masarray
masarray marked this pull request as ready for review November 18, 2026 09:34

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native c56a2c5

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T22:13:22.307399Z c61b94b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

@codex review

Please audit exact C++ MV-13 HEAD c56a2c594aff8b256789e16e86e3fc0acbce6c96 against main ddd734c3ffd880cf602efbbf9ee60216cfd9e59a. Focus on whether extracting native hotkey registration and dispatch into NativeHotkeyCommandPlan.h preserves legacy behavior, exact ChannelId/FX instance lease, callback-owned admitted graph, immutable readback, original onAction + handleApprovedNativeControl dispatch, PANIC/ParamID behavior and no new realtime path. Review Windows MSVC correctness, CMake, contract test relocation, and negative cases. Do not approve based only on Linux source contracts: Windows CTest pending.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: c56a2c594a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…tration admission

Keep single native ACK/control dispatcher, add pure native registration mapping plan and regression coverage; no PCM, device lifecycle or /preview/ rendering changes.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 54acf5b

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact native MV-13 HEAD 54acf5b933594300b95e8fda30fa46c9336128e3 against current main@698d76e06920decc66632e4324a0cc218af50870. Focus on the new pure NativeHotkeyCommandPlan::planRegistration and existing dispatch semantics, JUCE C++ MSVC compile correctness, WebView mapping sanitation, exact uint64 ChannelId and session/FX instance identity, APP PANIC, parameter service ownership, activation failure fencing, OS registration rollback, and no new PCM/RT paths. Verify source contract tests and ensure no GUI MV-17 overlap. Do not treat prior review at c56a2c5 or Linux-only tests as certification of this new commit.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 54acf5b

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 54acf5b933

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

Checkpoint Native MV-13 (2026-11-19 Asia/Jakarta)

Hasil: ConsoleWindow tidak lagi memiliki pengolahan detail mapping registrasi dan dispatch hotkey; NativeHotkeyCommandPlan memvalidasi mapping, native session lease, ChannelId, FX insert instance, dan menyusun command immutable. Tidak menyentuh GUI MVVM MV-17, PCM renderer, audio callback, device lifecycle, atau format .smix.

Commit implementasi: 54acf5b933594300b95e8fda30fa46c9336128e3; files: src/Main.cpp, src/NativeHotkeyCommandPlan.h, tests/native_hotkey_registry_test.cpp, tests/approved_native_gui_bundle_test.py, CMakeLists.txt.

Evidence (same SHA): Fast UI PASS; Fast Native PASS; latest Codex Review completed without findings. Full Chromium UI and Windows MSVC/CTest running at the last read; not yet qualified. Required CI Merge Gate pending; no installer and no hardware ASIO FAT.

Parallel integration: GUI MV-17 #797 has since merged, advancing main to 0ce20b58434cb7b26caa0b45a1a7f19b12fd56ec. Changed-file diff is disjoint from native PR. Branch ruleset ArSonMix - Protected Main requires up-to-date branch (strict_required_status_checks_policy=true); therefore after finishing current qualification/review diagnostics, reconcile exact main without resetting GUI work and qualify the new SHA before protected merge. Do not merge stale HEAD or pass off old checks as final.

Status owner: KODE DIBUAT dan fast contracts KODE DIUJI; BELUM MERGED; installer/hardware FAT NOT RUN. AMAN DIPAKAI: current main remains unaffected; new refactor not yet accepted as installer. TINDAKAN OWNER: tidak perlu apa-apa. Next: exact SHA Windows CTest + Chromium, reconcile latest main, protect-gated merge, then native-only next use case extraction under #527.

No overlapping source files. Preserve GUI MV-17 ACK/PCM timeout logic and all native hotkey use-case tests for protected required-check qualification.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 5086bae

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 5086bae

Copy link
Copy Markdown
Owner Author

@codex review

Review exact HEAD 5086baec43af5112ca1e15f6eb385a743414aa55 after reconciling GUI MV-17 main@0ce20b58434cb7b26caa0b45a1a7f19b12fd56ec. Ensure the merge preserves both pure native hotkey registration/dispatch and GUI SOURCE timeout/ACK fences without a second event/PCM authority. This is a same-code source reconciliation of previously reviewed 54acf5b with MV-17, not permission for GUI changes. Verify exact code and CTest integration.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 5086baec43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Reconcile without force, retain single native hotkey planner and all latest GUI source/control tests. No PCM graph or DSP changes.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 333b398

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 333b398

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact HEAD 333b398e405559d27933f57569571371bc03aad8, reconciled against current main@7c142caacfe359c0c25ddfb376c780c977e9ec4d. Focus on hotkey registration NativeHotkeyCommandPlan, preserving approved-native ACK/readback and precise session/ChannelId/FX-slot ownership, preventing audio/PCM authority duplication, CMake/CTest and maintaining the latest GUI bridge source contract untouched. Prior 5086bae review had zero findings; this request is for the updated SHA.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 333b398e40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

N-MOD native hotkey workstream — cross-thread audit handoff

Please read the shared GUI + Native architecture audit and acceptance rules before further code/merge decisions. This is a coordination note, not an approval to merge or a request to restart previous M1–M6.

Live checkpoint at posting: #792 OPEN, HEAD 333b398e405559d27933f57569571371bc03aad8; GUI MV-19 #800 MERGED, observed main b6dfd41393618e81f6518f53545926a6f8c90876. Therefore the original #792 base main is now behind; reconcile/verify with actual main before final promotion. Native #799 is also open and modifies src/Main.cpp and CMakeLists.txt.

Do next: complete exact-HEAD native MSVC/JUCE CTest and actual required commit-status verification; confirm current CI, no unsupported FAT claims. Preserve NativeHotkeyCommandPlan as a control-thread-only policy; ConsoleWindow should retain only the one OS registration/event wiring/accepted dispatcher it truly owns. Validate forged sessionId, precise uint64 ChannelId, FX insert identity after reorder, invalid/stale role/session/graph, PANIC and existing persistence. No alternate audio graph, device manager, transport, JS renderer or duplicate ACK path.

Before merge: recheck main SHA, preserve already-merged GUI MV-19 and all previous native service improvements. Coordinate resulting main SHA with #799, so its PlayerSetlistArchive branch can reconcile instead of accidentally overwriting the hotkey changes. Avoid merging or rebasing based on the stale #799 prose claiming this PR was already merged.

After this PR: measure real owner/coupling reduction, not the MV milestone number; cross-reference epic #527. Proposed naming: N-MOD for future native milestones (existing PR number/title may stay).

…e case

Source-only reconciliation of disjoint files on top of last Windows MSVC/CTest-qualified native hotkey SHA. No changes to native hotkey blobs; GUI MV-19 remains canonical.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native c61b94b

masarray commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner Author

CI dispatch attempt canceled before any Chromium runner was created (GitHub Actions dispatcher run #44409045319; zero jobs). Original operator request, retained for audit:

/arsonmix-ci ui c61b94b5d03c37c01f05eee0c6bb66f2bade721f

Superseded by a new exact-SHA UI request after native dispatcher completed. This is a queued-dispatch cancellation, not a failed Chromium qualification.

Copy link
Copy Markdown
Owner Author

@codex review

Review exact reconciled HEAD c61b94b5d03c37c01f05eee0c6bb66f2bade721f against GUI MV-19 main b6dfd41393618e81f6518f53545926a6f8c90876. The native hotkey source blobs are unchanged from Windows MSVC/CTest PASS 333b398e; ensure retaining GUI device snapshot admission and native ACK/PCM contracts without introducing duplicate authority. This is source-only branch reconciliation, no new DSP path.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: c61b94b5d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui c61b94b

Copy link
Copy Markdown
Owner Author

N-MOD continuation / CI triage (exact-source evidence):

  • Exact HEAD c61b94b5d03c37c01f05eee0c6bb66f2bade721f: Fast Native + Fast UI PASS, Codex review completed with zero findings.
  • Windows MSVC/realtime CTest run #44409083522: in progress, compiling the approved JUCE app/RT CTest.
  • UI run #44410039996 attempt 1 FAIL at Stage-C CSS pixel screenshot parity for (1366×768, default). Computed styles were identical; screenshot SHA differed. This was NOT a native hotkey/PCM contract error. Existing main b6dfd413 Full Chromium has PASS. Instead of altering GUI/weakening the pixel gate, I re-ran only failed Chromium job #135175746245 (run attempt 2 currently in progress).
  • The ready MV-14 patch was dry-run against this exact MV-13 tree. Seven player/CMake hunks match uniquely; the header include hunk needs a careful merge to preserve both NativeHotkeyCommandPlan.h and PlayerSetlistArchive.h. No force-push or GUI file overwrite.
  • No merge until strict Required CI Merge Gate returns SUCCESS on an up-to-date exact SHA. Keep device/GUI MV-19 and one PCM render owner untouched.

@masarray masarray changed the title refactor(mv13): extract native hotkey command use case from ConsoleWindow refactor(native N-MOD-13): isolate hotkey command use case Nov 18, 2026
@masarray
masarray merged commit c882766 into main Nov 18, 2026
45 of 46 checks passed

Copy link
Copy Markdown
Owner Author

N-MOD-13 — final merged checkpoint (2026-11-19 Asia/Jakarta)

MERGED MAIN: PR #792 squash commit c882766355b67daf4aa1b3df517cf45111847ea8, from exact qualified HEAD c61b94b5d03c37c01f05eee0c6bb66f2bade721f.

Bukti: Fast Native PASS, Fast UI PASS, Windows MSVC/realtime CTest #44409083522 SUCCESS, full approved /preview/ Chromium #44410039996 SUCCESS on retry (initial Stage-C CSS screenshot mismatch without source change), exact-head Codex review zero findings, required protected commit status success and branch clean immediately before squash merge.

Outcome: Native hotkey use-case planning is now extracted from ConsoleWindow; sole JUCE PCM graph/dispatcher/ACK authority unchanged, no alternate GUI, no custom driver. No new installer or physical ASIO FAT was produced. Aman untuk main source: YA menurut CI; hardware delivery: BELUM teruji.

Next: Integrated Player archive/Cue application policy N-MOD-14 #799 now depends on this merged source and is undergoing its own Windows CTest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant