Repository navigation
refactor(mv7b): fail-closed WIRE recovery and deferred SEND gain ViewModel - #784
Conversation
|
/arsonmix-ci ui 9a5cac0 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
46c2c5b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eb387907.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-mv7-wire-lifecycle.arsonmix.pages.dev |
Cross-thread reconciliation (MV-7A SOURCE vs MV-7B WIRE)Source audit on the exact Fast UI and Fast native checks for |
|
/arsonmix-ci ui 46c2c5b |
|
@codex review Please review the exact reconciled MV-7B HEAD |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
OWNER DELIVERY — ArSonMix MV-7B WIRE (18 Nov 2026)HASIL: Existing pure STATUS: MERGED MAIN — KODE DIUJI. PR #784 / original feature commit BUKTI: Exact merged-candidate Fast Native PASS, Fast UI PASS (260/260 native GUI contracts; zero failures), Full Chromium native /preview/ PASS (109 completed steps, run #44254702313); Required Merge Gate = SUCCESS before squash; Codex review completed with no findings. Exact post-merge push Windows/Chromium CI separately in progress when noted. Hardware ASIO FAT: NOT RUN; new Windows installer: NOT CREATED. AMAN DIPAKAI? YA as a tested JavaScript source refactor on main; BELUM as a new installer or physical hardware qualification. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. NEXT: Continue bounded MV-8 FX Rack transaction/pending lifecycle and the original native modular-monolith M2–M6; do not create a second native status owner or replay already-merged M1–M6. Preserve #783 SOURCE exact readback settlement, one ChannelId/EdgeId graph, SOURCE ONLY, PRE/POST, SOF, FX VST3 and physical output authorization. |
MV-7 — WIRE transaction lifecycle and deferred SEND gain safety
Outcome / HASIL: This implementation takes two remaining authoritative-PCM-dependent WIRE decisions out of the 4k-line
web/approved-native-bridge.jsand places them in the existing pureweb/approved-wire-view-model.js, with zero new controllers, stores, event buses or PCM/DSP owners.gainDispatchPlan: verifies admitted exact graph identity, canonical decimal-string ChannelId/EdgeId, a unique installed PARALLEL SEND, finite bounded gain and already-applied/no-op levels. A stale or duplicate EdgeId fails closed and the bridge restores accepted display rather than issuing a speculative command.nativeRecoveryPlan: identifies PENDING / ACCEPTED / IDLE / FLUSH_STARTUP_RETRY / REBASE_CONNECTION / ROLLBACK. A failed CONNECT may be rebased once only on identical native device epoch after the existing admission gate. REMOVE, RETARGET, timeout, device swap, unsupported request and stale graph are not automatically replayed.protocol.createControlleralone retains command dispatch, ACK correlation, installed native readback, timeout and publisher authority; the bridge retains UI side effects and timers. No synthetic WIRE state is authoritative.Files:
web/approved-wire-view-model.js,web/approved-native-bridge.js,tests/approved_native_m2_contract.test.cjs.Safety: JS-only existing /preview/ source; no changes to JUCE C++, ASIO, VST3, DSP, PCM, CSS/HTML/PNG, .smix schema, or independent dual-ASIO IO-1 draft #771. Preserve PRIMARY OUT vs PARALLEL SEND, SOURCE ONLY, no auto hardware ARM, and the approved GUI.
Validation: local source syntax / pure selector preflight PASS. Fast native/UI contracts, a full native-assembled Chromium run and Required Merge Gate at the exact HEAD must be verified prior to merge. Windows hardware FAT / installer NOT RUN.
Status / STATUS: KODE DIBUAT, DRAFT PR, CI PENDING. Aman dipakai? BELUM sebagai rilis/installer. Tindakan Anda: TIDAK PERLU MELAKUKAN APA-APA. Next: resolve genuine CI failures on this head, then reconcile to main and merge only with required checks; continue higher-level FX & native application ownership separately.