Repository navigation
Conversation
Owner
Author
|
/arsonmix-ci ui 81f756c |
Deploying arsonmix with
|
| Latest commit: |
81f756c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9dbf3d7f.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-mv8-device-apply-pi.arsonmix.pages.dev |
masarray
marked this pull request as ready for review
November 18, 2026 07:22
Codex Review Summary: 🔄 RunningThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MV-8 — Physical Device Setup identity, one existing pure ViewModel
Base:
main@7e2e2796259862ab25c16ae4237a39d7f5f6c1e2(includes merged WIRE PR #784). This PR is deliberately disjoint from #784: no edits toweb/approved-native-bridge.js,web/approved-wire-view-model.js, ortests/approved_native_m2_contract.test.cjs.Real reliability problem
On the same active hardware, the operator can explicitly choose input/output pin masks. Existing
setupBeginsent those masks to JUCE but forgot them in the pending transaction;setupAckandsetupReadbackonly compared what the driver reported to itself. This could announce an accepted Apply even if the actual physical pins differed from the operator's choice. At the same time, newly selected devices intentionally send empty pin arrays to let JUCE choose defaults; never treat these as an explicit request to disconnect every pin.Implemented
web/approved-device-view-model.js: one purevalidPinMaskandsamePinMaskpolicy used in draft eligibility, two-pin MAIN action, accepted driver ACK and independently installed schema-v6 readback. Rejects duplicates, fractions, out-of-range, phantom pins; compares canonical sets rather than callback array order. CapturesrequestedPinsfor same-endpoint explicit pin Apply; for changed devices leaves itnullso driver defaults work. A mismatched accepted ACK yieldsRECOVERY_REQUIREDand keeps device setup open; does NOT claim rollback or LIVE.tests/approved_device_pin_identity_contract.test.cjs: separate deterministic 7-test suite for same-mask reordering, explicit input/output mismatch, malformed masks, driver defaults on new device/output-only, timeout/late ACK and one native transport..github/workflows/ui-smoke.yml: run the new independent test in BOTH fast and full Chromium lanes; add exact trigger path.Invariants: ONE approved
/preview/renderer, ONE JUCE native ChannelId/EdgeId/VST3 PCM owner, existingarMixActionand native Apply coordinator. No C++/JUCE/DSP/ASIO/VST3/.smix changes, no new state store/controller, no GUI HTML/CSS/PNG/layout changes. Real hardware remains the only authority for pin availability and open status.STATUS: KODE DIBUAT / DRAFT. Fast UI/native and exact-head Chromium proof pending. Windows installer, live ASIO device FAT, and dual-interface hardware qualification NOT RUN. Tindakan Anda: TIDAK PERLU MELAKUKAN APA-APA.