Repository navigation
Premium licensing: embed AGPL and vendor notices in JUCE app and clean installer - #741
Conversation
… AGPL and vendor terms
… AGPL and vendor terms
… AGPL and vendor terms
… AGPL and vendor terms
…er regression tests
…er regression tests
…er regression tests
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
47da72d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0454cd21.arsonmix.pages.dev |
| Branch Preview URL: | https://feat-embedded-premium-legal.arsonmix.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 547835bed6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… touching user data
Retain latest native editor hotfix and alpha.25 release docs. Reapply only the three legal resource integrations to src/Main.cpp, preserve every main change, and integrate all 21 scoped legal-center files.
Final source-to-release verification — 2026-11-17Resolved and published, not merely source-merged. The official immutable Windows prerelease v0.5.0-alpha.26 points to source commit The official publisher run #44030667417 completed SUCCESS and its Windows x64 build, package and publish preview job
The newer main native run #44035826506 also completed SUCCESS (Windows MSVC/native regression). Historical red vs current: run #44030394471 failed on stale G5E editor-close test assertion in an older commit; corrected by merged PR #745. Failed/cancelled older workflow records remain in GitHub history and do not invalidate the successful release or later main qualification. There is no open legal/distribution blocker demonstrated by current CI. Real ASIO/WASAPI field verification remains separate from this AGPL licensing milestone. Please do not rerun old immutable failing workflows or overwrite the published alpha.26 assets merely to recolor historical history. |
Why
The merged #735 made AGPL-3.0-only legally explicit, but releases left many loose LICENSE/NOTICE .txt/.md files in portable and install roots. Public alpha.24 predates #735.
Native implementation
ARMixAssetsBinaryData library. Preserve original full AGPLv3, HRIR MIT, Signalsmith MIT, Inter OFL and optional VB-CABLE notice.WebBrowserComponentresource routes/legal/*, no disk lookup, network fetching or PCM processing.dontcopyembedded setup content, without a new license/consent wizard, and installs no top-level legal documents.LICENSEremains untouched.Gates
node --test tests/license_distribution_contract.test.mjspython scripts/verify_embedded_legal.py --self-testnode --check web/approved-native-legal.jsNo new release is claimed by opening this PR, and no audio/DSP/routing implementation changes are intended.