Skip to content

Premium licensing: embed AGPL and vendor notices in JUCE app and clean installer - #741

Merged
masarray merged 34 commits into
mainfrom
feat/embedded-premium-legal-center-20261117
Nov 17, 2026
Merged

masarray merged 34 commits into
mainfrom
feat/embedded-premium-legal-center-20261117

Conversation

@masarray

Copy link
Copy Markdown
Owner

Why

The merged #735 made AGPL-3.0-only legally explicit, but releases left many loose LICENSE/NOTICE .txt/.md files in portable and install roots. Public alpha.24 predates #735.

Native implementation

  • Compile seven exact source legal notices into the already existing JUCE ARMixAssets BinaryData library. Preserve original full AGPLv3, HRIR MIT, Signalsmith MIT, Inter OFL and optional VB-CABLE notice.
  • Expose those resources via read-only WebBrowserComponent resource routes /legal/*, no disk lookup, network fetching or PCM processing.
  • Add one unobtrusive native-only entry More > About & Licenses, a compact keyboard-accessible scrollable offline legal center (copy text, explicit open exact source SHA). Do not modify approved Pages /preview/ DOM/visuals or session/FX/audio engines.
  • Inno carries the original notices as dontcopy embedded setup content, without a new license/consent wizard, and installs no top-level legal documents.
  • Portable Windows ZIP / Linux tar.gz / macOS DMG no longer scatter redundant legal text files. Original repository LICENSE remains untouched.
  • Independently scan the actual compiled binary for exact source license bytes and fail closed in packaging/FAT. Preserve source SHA and license hashes in provenance. Fast negative self-tests and no-clutter Inno smoke.

Gates

  • node --test tests/license_distribution_contract.test.mjs
  • python scripts/verify_embedded_legal.py --self-test
  • node --check web/approved-native-legal.js
  • Windows native release binary scanner / installed PE and Inno graceful-upgrade FAT, plus platform package scanners.

No new release is claimed by opening this PR, and no audio/DSP/routing implementation changes are intended.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T04:11:33.729467Z 547835b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 47da72d
Status: ✅  Deploy successful!
Preview URL: https://0454cd21.arsonmix.pages.dev
Branch Preview URL: https://feat-embedded-premium-legal.arsonmix.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 547835bed6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masarray
masarray merged commit 815f2f3 into main Nov 17, 2026
22 checks passed

Copy link
Copy Markdown
Owner Author

Final source-to-release verification — 2026-11-17

Resolved and published, not merely source-merged. The official immutable Windows prerelease v0.5.0-alpha.26 points to source commit 8ec5b8a3e07837c85fb6e06c952cff1621fecc51, a direct descendant of PR #741 merge 815f2f39153b8944d7de1bbacc01c93bc1a40f63.

The official publisher run #44030667417 completed SUCCESS and its Windows x64 build, package and publish preview job 133861581389 passed:

  • Real native JUCE build, source-exact portable packaging and independent distribution audit
  • ARSONMIX_EMBEDDED_LEGAL_BINARY_PASS three times (packaged EXE, independent verification, installed EXE), checking all seven exact original notices
  • INNO_GRACEFUL_UPDATE_PASS (installed EXE restored, running editor shutdown, user data retained)
  • Verified Setup/portable assets and SHA256 checksum publication, landing refresh

The newer main native run #44035826506 also completed SUCCESS (Windows MSVC/native regression).

Historical red vs current: run #44030394471 failed on stale G5E editor-close test assertion in an older commit; corrected by merged PR #745. Failed/cancelled older workflow records remain in GitHub history and do not invalidate the successful release or later main qualification. There is no open legal/distribution blocker demonstrated by current CI. Real ASIO/WASAPI field verification remains separate from this AGPL licensing milestone.

Please do not rerun old immutable failing workflows or overwrite the published alpha.26 assets merely to recolor historical history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant