Repository navigation
Align post-alpha.26 release docs and native Show dual-editor lifecycle test - #744
Merged
masarray merged 6 commits intoNov 17, 2026
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e34b9e2fea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…y after main merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The official Windows v0.5.0-alpha.26 has published from immutable source
8ec5b8a3e07837c85fb6e06c952cff1621fecc51after #741 merged. The README still pinned alpha.25.Exact changes
docs/releases/v0.5.0-alpha.26.mdfrom the release branch to main documentation.tests/live_routing_ui_contract_test.mjs, G5E Show recall). The accepted alpha.25 ImmerSIB editor lease fix changed Show recall fromsafe->closePluginEditor()tosafe->closeAllPluginEditors(); assert both the call and the implementation that closes generic VST3 and ImmerSIB leases. This test-only correction preserves actual lifecycle safety, not a bypass.No audio engine, GUI production source, installer, or published release assets are modified. Previous 353/354 Windows source tests passed; the stale assertion accounts for the one failure in main push run 44030394471.