Skip to content

test(gui): repair real Chromium cold-start expectation to accepted Audio connection lost label - #519

Merged
masarray merged 1 commit into
mainfrom
test/browser-coldstart-retained-device-label-20261110
Nov 10, 2026
Merged

masarray merged 1 commit into
mainfrom
test/browser-coldstart-retained-device-label-20261110

Conversation

@masarray

Copy link
Copy Markdown
Owner

What failed in real main browser CI

Main CI #42767087530 reached the real native Harmony editor fixture successfully, then the subsequent unrelated cold-start fixture failed on line 297 expecting Waiting for device.

The authoritative web/approved-native-bridge.js existing main code has const NEEDS_REMAP="Audio connection lost";, and explicitly assigns that label to an INPUT when its original ChannelId was retained but the physical device epoch is unavailable. This is a real current GUI label; the fixture's legacy expectation became stale. Updating one expectation to exact current label and asserting no operator-facing REMAP string.

No native routing, device code, operator UX, Harmony DSP, plugin picker, audio callback, or web UI implementation changed. This does not solve actual ASIO device-recovery issues in separate #512; it restores QA fidelity for behavior already in main.

Gate

Fast UI contracts first, then one full real Chromium /preview/ run (exact SHA). Do not merge solely on a modified assertion if the browser suite still fails somewhere else. Related branded main #517 already passed full Windows CTest 80/80.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 58a1a0b

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58a1a0b
Status: ✅  Deploy successful!
Preview URL: https://1c5a3bbe.arsonmix.pages.dev
Branch Preview URL: https://test-browser-coldstart-retai.arsonmix.pages.dev

View logs

@masarray
masarray marked this pull request as ready for review November 10, 2026 06:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T06:35:51.648180Z 58a1a0b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant