Repository navigation
test(gui): repair real Chromium cold-start expectation to accepted Audio connection lost label - #519
Merged
masarray merged 1 commit intoNov 10, 2026
Conversation
…echnical device-loss label
Owner
Author
|
/arsonmix-ci ui 58a1a0b |
Deploying arsonmix with
|
| Latest commit: |
58a1a0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1c5a3bbe.arsonmix.pages.dev |
| Branch Preview URL: | https://test-browser-coldstart-retai.arsonmix.pages.dev |
masarray
marked this pull request as ready for review
November 10, 2026 06:34
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed in real main browser CI
Main CI #42767087530 reached the real native Harmony editor fixture successfully, then the subsequent unrelated cold-start fixture failed on line 297 expecting
Waiting for device.The authoritative
web/approved-native-bridge.jsexisting main code hasconst NEEDS_REMAP="Audio connection lost";, and explicitly assigns that label to an INPUT when its original ChannelId was retained but the physical device epoch is unavailable. This is a real current GUI label; the fixture's legacy expectation became stale. Updating one expectation to exact current label and asserting no operator-facingREMAPstring.No native routing, device code, operator UX, Harmony DSP, plugin picker, audio callback, or web UI implementation changed. This does not solve actual ASIO device-recovery issues in separate #512; it restores QA fidelity for behavior already in main.
Gate
Fast UI contracts first, then one full real Chromium
/preview/run (exact SHA). Do not merge solely on a modified assertion if the browser suite still fails somewhere else. Related branded main #517 already passed full Windows CTest 80/80.