Repository navigation
integration(release): consolidated ArSonMix public mixer — source for alpha.8 - #505
Conversation
…amps and ASIO block parity
… with stereo PCM regressions
…vals with tonal parity regressions
… and hostile-PCM safety
…ss graph/device changes
… and lost/recovered FX without reopen
…atic open-gate assertion
…fter automatic rebind
…puts Output-only DIRECT fences and callback mask validation now permit zero capture without inventing input pins. A verified SOURCE NONE startup publishes the same authoritative native PCM graph used for FX, track and WIRE editing. Preserve output muting and driver identity, add zero-capture regression cases.
…ter, persist 0-input sessions Only a verified ten-channel SOURCE NONE starter may enter native ChannelId without physical capture. Keep M4 fail-silent until admission, retain exact device fence and enable portable .smix roundtrip with zero capture. Extend tests.
…der true zero PCM Adapt startup banner contract to zero-capture no longer blocking FX, add JUCE-backed 0-IN 2-OUT ChannelId bootstrap/track/PCM test; retain M4 unpatched refusal.
…al voice liveness
Allow explicit NONE capture for separate Windows audio endpoints and empty enabled capture masks for genuine ASIO devices, preserving exact verified stereo outputs, user choice, DIRECT fencing and readback. Match native bridge device Apply/ACK to accepted zero-capture graph; add regression contract.
…fied device restore Reject missing/stereo-incomplete playback but do not require a microphone when restoring the exact saved output-only endpoint. Retain DIRECT fingerprint and fail-silent guards. Repair advanced setup guidance and add regression test.
… VST3 scanner Keep verified third-party catalog and Show/backup/handoff gates, but make native built-in FX available on initial SOURCE NONE workspace while background plugin scan is busy. Add guard contract regression.
… VST3 discovery Built-in JUCE processors are already present in the executable: expose them in the approved Windows picker on first paint and after every external catalog refresh. Label their real native format, without fake vendor metadata or browser DSP.
…rs available before VST3 scan
…t timing, intonation and early reflections
…er on cold boot The always-on ChannelId graph is real PCM, but on fresh startup must not make the saved Show unrecoverable. Permit replaceActive only for unmodified silent starter on exact verified device; do not overwrite authored FX/WIRE/track edits. Prove native 0-input saved Show restoration and regression safety.
…ed cold-start graph
…while MAIN remains muted
…/updater integration without overwrites
…ible switch slope against aligned PCM
…nelId guide across ASIO buffers
…s PCM and multi-rate CPU proof
…annelId roster Delete unconditional visibility:hidden startup rule from approved native GUI assembly. Keep bridge ACK/graph authority, SOURCE NONE/0-IN and one /preview/ renderer. Add reversible native-bundle regression to prevent blackout on ASIO4ALL restart or initial offline session.
… altering shared chrome Avoid .mx-comp-close/.mx-comp-power selector collision that breaks real Compressor Chromium FAT when both built-ins are installed. Preserve semantic .armix-builtin-fx controls, 24/26px geometry and readback state; assert uniqueness in dedicated Vocal Throw smoke.
… cross-feature branch
…ous Music key into integrated PCM QA
…out indefinite stale key
…usic key staleness
…M transitions across ASIO partitions
…/Space matrix, silence and rack toggles
…and polished operator GUI
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…llback FAT fixture
Deploying arsonmix with
|
| Latest commit: |
ca80dec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19a769e6.arsonmix.pages.dev |
| Branch Preview URL: | https://releases-alpha-v0-5-0-alpha-3t90.arsonmix.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f586d81c34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const auto available=std::min<std::uint64_t>(end,recorded_); | ||
| const auto count=std::min<std::uint64_t>(available,settings_.captureSamples); |
There was a problem hiding this comment.
Bound frozen captures to the post-invalidation history
After bypass/re-enable, invalidateCaptureHistory() clears recorded_ but deliberately preserves clock_. If a new phrase ends before the cue, recorded_ also includes the subsequent silence, so this calculation permits the capture to extend before the invalidation boundary and replay old vocalist audio. A standalone 48 kHz reproduction with 1.5 s capture, pre-bypass PCM at 0.9, then 100 ms of new PCM at 0.1 and 300 ms silence produces an accepted throw peaking at 0.9. Bound the available history relative to end by excluding clock_ - end, rather than treating all currently recorded frames as preceding the phrase.
Useful? React with 👍 / 👎.
| if(const auto pair=uniqueNamedSpeakerPair(newPins,live.outputNames)) | ||
| return {count,pair->first,pair->second,-1,-1,false}; |
There was a problem hiding this comment.
Require explicit approval before substituting MAIN outputs
When the saved MAIN connectors disappear during an ASIO4ALL restart, this fallback silently substitutes a different speaker pair based on its labels. The automatic serviceAsioMixerRestart() path accepts that replacement through reattachRetainedAsioMixer() and can then call requestAutomaticMain(false) using the previous monitoring intent, making the live mix audible on previously unapproved outputs. A unique speaker pair does not establish that it is the user's intended destination. Keep the session muted and require the existing explicit MAIN-pin selection action when the saved pair cannot be resolved; AGENTS.md expressly prohibits silent output rerouting.
AGENTS.md reference: AGENTS.md:L73-L75
Useful? React with 👍 / 👎.
| needs: quick | ||
| # Run dedicated Vocal Throw visual validation in the reconciled native | ||
| # engine branch too; generic /preview/ smoke does not call this fixture. | ||
| if: ${{ github.event_name == 'pull_request' && (startsWith(github.head_ref, 'feature/arson-vocal-throw-') || startsWith(github.head_ref, 'integration/arson-vocal-throw-') || github.head_ref == 'integration/asio4all-harmony-d4-compat-20261109') }} |
There was a problem hiding this comment.
Gate the Vocal Throw browser job on milestone dispatch
In the inspected ui-smoke.yml, pull_request.types includes synchronize, so every relevant push to any of these matching branches runs this new job after quick, including installing Playwright/Chromium and executing the desktop/mobile browser suite. Conversely, its PR-only condition excludes the authorized workflow_dispatch UI milestone. Move this qualification into the exact-SHA dispatched UI lane instead of automatically running it per commit; AGENTS.md explicitly restricts ordinary PR synchronization to lightweight checks.
AGENTS.md reference: AGENTS.md:L79-L82
Useful? React with 👍 / 👎.
|
Release integration blocker (smart updater): The current alpha.7 integration branch embeds an older #501 updater snapshot ( |
…-closed health into alpha.7
Merge validated main updater #501 while retaining alpha.7 native Harmony/Player/Vocal Throw graph and GUI. The 10 main-changed updater file paths were compared; 7 are byte-for-byte identical, Main.cpp's entire ConsoleApp is identical and release workflow/CI variants preserve the same gates plus integration-specific tests. No release artifact is published by this commit.
|
Updater reconciliation applied. alpha.7 integration now includes the final #501 updater script, exact-image and rollback contracts, documentation, and JUCE |
|
RELEASE FREEZE / SOURCE COORDINATION (2026-11-10) Public delivery is being handled via exact-source release controller; DO NOT push to The original alpha.7 publisher run 42723531391 is pinned to |
Public alpha.7 release integration — owner-authorized public preview
Goal: offer the public a substantially more capable ArSonMix digital mixer than the published alpha.5, while continuing optimization separately. Owner confirms practical use of the current feature set is suitable for public preview. This does not assert universal hardware/ASIO certification.
Immutable source recipe
fe4edaa94e018004b6a9b4d0d89c01b1be2554c3(descendant of DRAFT M14 — 80/80 Windows FAT qualified Vocal Throw + Player + Harmony (hardware trial) #499 integrated 80/80 Windows FAT) preserving native PCM, ArSon Player, Harmony, Vocal Throw, ASIO4ALL, WIRE, session and compressor.c5f58dd15efb402d1f12de27fa5f4925f71cade6update supervisor, Inno setup and offline/install smoke; preserve already integrated updater native launcher insrc/Main.cpprather than clobbering the latest integration.af1589d81a1c01ba0b890c6657a0269da7b490e2native header and matching caption contract. Bridge user-facing status sanitizer ported narrowly onto integration bridge, without replacing Vocal Throw/Harmony/Player bridge code.FAT PENDINGand require plain operator guidance.docs/releases/v0.5.0-alpha.7.md; no artifact published merely by opening this PR.Gates and CI efficiency
releases/alpha/v0.5.0-alpha.7SHA, to runalpha-preview-publish.ymlonce. Publisher already does complete Windows MSVC build, all CTests, approved GUI, portable artifact verification, Inno upgrade/close/uninstall, SHA256 and provenance and only then publishes a public prerelease. Do not redundantly dispatchnativeorfatfor same source.Current release candidate commit:
f586d81c34c3bf5c3eccb2c4c33ed2ebe59f902f. Any change requires a new exact SHA and requalification.