Skip to content

Desktop: native JUCE SVG caption and event-driven WIRE geometry on resize - #498

Closed
masarray wants to merge 22 commits into
mainfrom
feature/native-caption-wire-geometry-20261109
Closed

masarray wants to merge 22 commits into
mainfrom
feature/native-caption-wire-geometry-20261109

Conversation

@masarray

@masarray masarray commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

ArSonMiX desktop titlebar and responsive cable geometry

Base: main d46aaa6b18ce94f5908c5db4f33ccba7d69947b4. This PR does not change the audio callback, PCM graph, sessions or device routing.

Implementation

  • Windows main mixer only: JUCE DocumentWindow uses a compact custom non-native caption and the three exact operator-provided 24×24 SVG paths (close / minimise / maximise). Buttons are native JUCE controls, not asynchronous WebView2 commands. Includes restore glyph, focus, hover, native caption drag and JUCE resize constrainer. Plugin and audio-setup windows retain their normal OS titlebars; non-Windows platform titlebar unchanged.
  • Split-color Ar / Son / MiX branding, concise native subtitle, remove duplicated HTML title only when the native JUCE bridge exists. Public browser GUI retains its own branding. Align 34px control toolbar and its narrow-width spacing without replacing BTN-180 design.
  • Fix WIRE redraw when maximising, restoring, minimising/reopening, DPI-size changes and live resizing: one coalesced RAF, ResizeObserver on viewport / tracks / master, resize / focus / pageshow / visibility events, recompute actual DOM pin rects. Only rerender all tracks if bank capacity changes; otherwise rerender the SVG geometry without graph mutations, routing changes, timers or idle polling.

Quality

  • Embedded GUI JavaScript parses successfully; source checks confirm original SVG paths and native scoped titlebar.
  • Fast CI includes a new zero-dependency node --test contract that simulates repeated resize, changed bank capacity, minimise/restore, hidden and zero-size WebView.
  • The user's real Windows maximise/minimise/drag/snap behaviour must be verified by an exact-head Windows MSVC and live desktop visual FAT before merging or claiming hardware certification. PR is intentionally draft until that evidence is green.
  • CI discipline: one PR and fast preflight, no redundant Windows build/release/installer or changes to concurrent Player/Harmony/Throw/ASIO work.

Follow-up audit and exact-SHA evidence (Nov 9, 2026)

Release gate: do not automatically merge or promote this draft without confirming native MSVC/CTest and practical Windows titlebar interactions (minimise, maximise/restore, drag, resize/edge snapping, DPI and WIRE endpoints). No hardware/Windows GUI FAT claim is made by JS and source tests alone.

Native resize reliability follow-up — fbc4bff

  • Correctly retire an in-progress cable replug before the bank DOM is rebuilt on resize, release the old actual pointer-capture node and clear dragged/snap CSS. No new WIRE edge is committed by window geometry.
  • Retire in-progress fader pointer capture on structural remount while keeping the last accepted gain untouched.
  • Coalesced ResizeObserver, visualViewport.resize and scroll/visibility/focus events; MAIN mini-cables and large SVG cables remeasure physical pins, without timers or PCM graph mutations.
  • Added tests/desktop_wire_resize_chromium_smoke.py: generated PUBLIC /preview/ only, real Chromium drag CH05→CH03, dynamic viewport widths/heights, SVG endpoints measured against actual socket centers, collapsed/expanded banking, and canceled in-flight WIRE gesture under structural resize.
  • Corrected test assumptions for both animated (L) and settled (C) cables and CSS minimum viewport bank width. These are test corrections, not retries that silently bypass failed endpoint assertions.
  • Fast PR contracts on final SHA: UI and native passed.
  • Exact-SHA Chromium qualification: https://github.com/masarray/arsonmix/actions/runs/42652111343
  • Exact-SHA Windows MSVC/CTest + portable ZIP + Inno Setup preview: https://github.com/masarray/arsonmix/actions/runs/42652147491

Promotion policy: This PR remains draft until both qualification lanes are green and an operator checks Windows titlebar drag/restore/minimise + WIRE socket alignment on the artifact. No code change to JUCE real-time callback or PCM device ownership.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 31de872
Status: ✅  Deploy successful!
Preview URL: https://9e5fdbd8.arsonmix.pages.dev
Branch Preview URL: https://feature-native-caption-wire.arsonmix.pages.dev

View logs

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci native 519ba23

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 519ba23

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 53e1ac0

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui af20b5c

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui adb73a9

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui fbc4bff

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat fbc4bff

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Milestone QA — desktop caption / WIRE resize

Exact source commit: fbc4bffeb6ba5543f8a15edb5edf39ebb5afe91a (no merge to main).

Operator Windows FAT required before merge: open app repeatedly; drag titlebar; double-click maximise/restore; minimise via provided SVG and restore from taskbar; Windows Snap/Win+Arrows; resize 1100×650 to maximised (including DPI scaling); confirm WIRE cables align at both actual sockets and MAIN stub, routes unaffected; switch plugin editor and confirm playback unaffected. No real ASIO device certification from headless Chromium.

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui f631afc

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat f631afc

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Native caption + professional header toolbar iteration — f631afc

Based on operator screenshot at 1646×928:

  • JUCE window control footprint 44→34px, original supplied SVG glyphs scaled 15→12px (30×25px rounded state face only; 34px native clickable hitbox).
  • Instant native hover/pressed feedback with red close, cyan-teal minimise, blue maximise/restore; zero JS commands, timers, or audio callback operations.
  • Desktop native command bar 35→43px, 8px default intra-command gap, 12px side padding, four dedicated lightweight group dividers (file / libraries / routing / channels-monitor) plus existing BANK separators. At ≤1360px the optional group dividers disappear and spacing tightens; at ≤1150px it compacts further without changing operator commands.
  • Save/Open native .smix actions, Player, Routes/Matrix/Wire Setup, Add Track, Mute Output, Audio I/O, bank selection and More retain original event ownership. The public /preview/ skin/geometry remains unchanged.
  • tests/native_header_toolbar_chromium_smoke.py measures 1680, 1366, 1200 and 1100px native-assembled WebView, checks 43px toolbar, visible controls do not overlap or overflow, tests file Save/Open event actions and More open/close.
  • Historical V28 CSS byte parity remains strict: strip only the new isolated native toolbar extension before its existing 1600-character legacy caption gate.

PASS full Chromium exact SHA: https://github.com/masarray/arsonmix/actions/runs/42658409988 including new native-header test, all baseline GUI/WIRE/FX regressions.

Windows JUCE MSVC+CTest+installer: https://github.com/masarray/arsonmix/actions/runs/42658928483 (qualification in progress when noted).

Release gating: PR deliberately stays draft; native hardware/Windows manual inspection of native window chrome hover, click, drag, snap, restore and high-DPI still necessary.

masarray added a commit that referenced this pull request Nov 9, 2026
…iven WIRE resize with Harmony, ASIO, Player and updater

Integrate exact latest #498 source with uniquely matched context; retain ASIO contracts and Player M3 listener. Add native GUI smoke tests without duplicating JUCE PCM ownership. Draft integration only.

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 184f3a0

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 184f3a0

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

2026-11-10 Reconciliation checkpoint — 184f3a0

Rebased through an explicit two-parent reconciled Git tree on main 9bd81a1b8da764a2f4523e70c0db60f583aa291f. The PR is behind main by zero commits, remains mergeable and draft. This is not a force push; old feature history is retained.

Critical cross-thread preservation: main ArSon Player M3 per-song KEY/TEMPO, including playerTrackSettings_, JSON v2 setlist, native setPlayerPitchTempo, and playerKeyMinus/playerTempoPlus UI survive intact. Native titlebar ArSonWindowChrome.h, compact 34px buttons, fast press colors, 43px desktop toolbar, and geometry-only WIRE resize survive intact. Fast source tests now assert the co-presence of both features. Source change is UI/native-window integration, not a modification to the JUCE audio callback or native graph.

Exact merged SHA qualification (dispatched once per lane):

Release guard: leave PR draft until exact-merged-SHA qualification is complete and the real Windows titlebar/snap/restore/hover workflow has been visually checked on the artifact. Preserve competing Harmony, Throw, and updater implementation threads; no auto-merge.

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui d2405d5

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat d2405d5

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui af1589d

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat af1589d

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 10db1c9

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 31de872

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 31de872

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

P0 Public-facing text cleanup — 31de872

Addressed operator FAT/internal status leakage from the Windows screenshot:

  • Native JUCE caption renders a single continuous three-color ArSonMiX wordmark and polished subtitle: Open Source Premium Digital Mixer · Version 01.00 · © 2026 SonKuPik. Middle dot and © created from explicit Unicode code points, not vulnerable source-font mojibake.
  • Existing close/minimise/maximise SVG control hitboxes remain 34px / icon 12px; hover outline and stronger click fill are native JUCE repaints, not timers or web scripts.
  • Root cause corrected: native footer sanitization previously watched #info and .warning but omitted #transport. It now watches all three lanes and sanitizes direct transport writes; any native QA/PCM/FAT note is translated to Mixer ready, Output enabled, or Output muted rather than exposing engineering internals.
  • Regression contracts cover exact unprofessional strings including HARDWARE FAT PENDING, FAT PENDING, NATIVE PCM GRAPH ACCEPTED in each footer field at four native Chromium viewport widths.
  • Preservation: no changes to graph routing, playback pipeline, Audio I/O controls or public /preview/ reference; diagnostics remain inside internal runtime, not operator-facing text.

Fast UI/native contracts PASS on exact SHA. Full UI and Windows FAT dispatched once via comment, do not duplicate runs. PR stays draft until Windows interaction verification.

masarray added a commit that referenced this pull request Nov 10, 2026
Forward-port production deltas from #512/#511, #500, and #498 without reverting the newer logical mixer or branded Harmonice. Fence generic ASIO recovery by registered driver and original pins, preserve saved capture patches, keep the native GUI readiness handshake independent of hardware, and verify unique USB-file relinks and sanitized native footer status.

Copy link
Copy Markdown
Owner Author

Repository housekeeping (2026-11-10): Closed as already integrated/superseded, NOT merged from this PR. The native JUCE caption (src/ArSonWindowChrome.h), responsive WIRE redraw, approved Pages assets and matching GUI/geometry tests are present in current main following merged integrated M14 #499. The remaining differences against this old PR are subsequent brand/native-message and other integration changes, not a reason to re-merge its older window/bridge source. Closing the historical duplicate PR (without merging); real Windows window controls/DPI/WIRE visual acceptance is still a separate field/UAT gate in #389/#412.

Historical code review and SHA remain available; this is not a hardware qualification or new release.

@masarray masarray closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant