Repository navigation
ci: skip redundant Pages publish on test-only main pushes; retain V59 WIRE gate - #388
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22fde33309
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| elif [ "${{ github.event_name }}" = "workflow_run" ] && git diff --quiet HEAD^ HEAD -- \ | ||
| site/ web/ AR-MIX-Live-FX-Host-Standalone-v0.3.html \ | ||
| scripts/build_pages.py scripts/build_ui_css.py; then |
There was a problem hiding this comment.
Compare against the last published revision before skipping Pages
If a GUI-changing main push A is followed by a test-only push B before A publishes, neither revision will deploy: .github/workflows/ui-smoke.yml:48–50 allows B to cancel A's verification, and the Pages publisher's existing obsolete-head guard skips A even if its verification finishes. B then passes this new parent-only comparison and skips publication despite containing A's unpublished GUI changes. The public preview consequently remains stale until another GUI change or manual dispatch. Base the skip decision on the last successfully published revision, rather than assuming the immediate parent was deployed.
Useful? React with 👍 / 👎.
CI milestone 2: no wasted Pages deployment after test/workflow-only pushes
Follows merged #386 (fast Chromium 1.6 min, Windows full CTest pass). This improves existing 4-workflow topology; no new workflow.
pages-publish.yml: on successful Chromiummainpush, compare qualified exact SHA with its first parent (shallow depth 2). Publish only whensite/,web/, standalone preview HTML or static-build scripts actually changed; stop redundant deploy fromtests/*.py, tests-only JS and workflow config edits.workflow_dispatchpublish always available. Do not respond to PR-only CI.ui-smoke.yml: addtests/wire_main_native_handoff_contract.test.cjsto precise PR/main path triggers. Its existing V59 native-handoff check remains in the fast suite following Reconcile V59 MAIN GUI to native WIRE v8 ENGINE/GUI/FAT ownership #385; future edits to that critical test no longer skip CI.tests/ci_workflow_efficiency_test.mjswith the new trigger and Pages gating regressions.What is unchanged: native JUCE/PCM CMake + full CTest for engine changes; packaging on main/FAT; approved V59 GUI; real audio stop-ship #15; release workflow owner boundaries.
Acceptance: exact PR-head UI smoke success, then merge; main Pages should skip this workflow/test-only commit, but future changed GUI assets must still publish.