Repository navigation
CSS V28 — Reconcile 13 KB inline CSS into Chrome owner; preserve ONLY approved /preview/ - #390
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
💡 Codex Reviewarsonmix/site/preview-v2/index.html Lines 14 to 15 in ef5f8be Removing the final AGENTS.md reference: AGENTS.md:L7-L7 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Final GUI authority clarification for CSS V28: The user-approved product is ONLY https://masarray.github.io/arsonmix/preview/ (current internal HTML/WIRE/FX/fader source plus approved site/preview-buttons/assets PNG hardware-button CSS/JS/sprite). Bare /preview-v2/ appearance is explicitly rejected, and its public URL is redirect-only. Before merging, ensure V28 remains byte/render/interaction-compatible with generated dist-pages/preview/index.html and approved PNG hardware keys, not merely isolated bare-v2 screenshot. Do not introduce a second public/native GUI. The single GUI release test is tests/single_preview_publication_contract_test.py; Pages must continue to pass. |
…approved /preview/ and CI lock
b3221ca to
1620a90
Compare
Reconciled against current approved sole /preview/ (not deprecated /preview-v2/)
Source baseline:
main@46f600b143c8ef000a717ccb79a9c841a2589766, including bindingAGENTS.md, single-preview publication contract, PNG switch material and latest WIRE/ENGINE docs. This PR's prior stale V59 lock expectation was the reason for CI failure. Rebuilt exact branch commit1620a902d836f7c3857ff0d6955823c3eb074784from current main (one commit ahead, no behind), preservingtests/gui_baseline_lock_test.py,AGENTS.md,scripts/build_pages.py, and single/preview/publication without edits.13,043 characters of late inline V15–V28 material CSS moved byte-identically to the END of the immediately preceding existing Chrome owner; remove 2 empty + 1 migrated
<style>nodes.old Chrome + inline == new ChromeEXACT, all 118 migrated!importantunchanged, no CSS declarations removed or added, no JS/ENGINE/DOM/control contract changed. HTML link only cache bust. The internalsite/preview-v2source feeds the deterministic sole/preview/assembly with approved PNG MUTE/SOLO/PFL assets; never publish an alternate GUI.Evidence: reversible immutable SHA/length source fixture and
tests/css_v28_restore.py, cheap byte-exact lock on every GUI CI, 5 viewport × 8 folded rail states, 3 viewport material/interactive/pseudo/token comparisons, all real.appelements × 48 properties × 9 viewport-density configurations intests/pages_css_architecture_v28_smoke.py. Full Chromium test on V28 PR, quick on other PRs. Existing single public preview publisher/PNG contract and all historical migration fixtures retained.Merge only after exact-head CI success and no fresh main drift, then verify exact-main CI and Pages build + deploy. Next V29: remove genuinely dead owner declarations proven by computed cascades, not by arbitrary stylesheet reordering.