Skip to content

CSS V28 — Reconcile 13 KB inline CSS into Chrome owner; preserve ONLY approved /preview/ - #390

Merged
masarray merged 1 commit into
mainfrom
css/v28-chrome-owner-v59-smart-ci-20261104
Nov 4, 2026
Merged

masarray merged 1 commit into
mainfrom
css/v28-chrome-owner-v59-smart-ci-20261104

Conversation

@masarray

@masarray masarray commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Reconciled against current approved sole /preview/ (not deprecated /preview-v2/)

Source baseline: main@46f600b143c8ef000a717ccb79a9c841a2589766, including binding AGENTS.md, single-preview publication contract, PNG switch material and latest WIRE/ENGINE docs. This PR's prior stale V59 lock expectation was the reason for CI failure. Rebuilt exact branch commit 1620a902d836f7c3857ff0d6955823c3eb074784 from current main (one commit ahead, no behind), preserving tests/gui_baseline_lock_test.py, AGENTS.md, scripts/build_pages.py, and single /preview/ publication without edits.

13,043 characters of late inline V15–V28 material CSS moved byte-identically to the END of the immediately preceding existing Chrome owner; remove 2 empty + 1 migrated <style> nodes. old Chrome + inline == new Chrome EXACT, all 118 migrated !important unchanged, no CSS declarations removed or added, no JS/ENGINE/DOM/control contract changed. HTML link only cache bust. The internal site/preview-v2 source feeds the deterministic sole /preview/ assembly with approved PNG MUTE/SOLO/PFL assets; never publish an alternate GUI.

Evidence: reversible immutable SHA/length source fixture and tests/css_v28_restore.py, cheap byte-exact lock on every GUI CI, 5 viewport × 8 folded rail states, 3 viewport material/interactive/pseudo/token comparisons, all real .app elements × 48 properties × 9 viewport-density configurations in tests/pages_css_architecture_v28_smoke.py. Full Chromium test on V28 PR, quick on other PRs. Existing single public preview publisher/PNG contract and all historical migration fixtures retained.

Merge only after exact-head CI success and no fresh main drift, then verify exact-main CI and Pages build + deploy. Next V29: remove genuinely dead owner declarations proven by computed cascades, not by arbitrary stylesheet reordering.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T11:17:18.981122Z ef5f8be PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

<link rel="stylesheet" href="assets/mixer-chrome-material.css?v=css-v28-inline-physical-console">
<link rel="stylesheet" href="assets/mixer-control-keys.css?v=css-v26-retired-socket-pruned">

P1 Badge Update the Pages builder when removing all inline styles

Removing the final <style> element breaks the production Pages build: scripts/build_pages.py:49 still asserts that the selected HTML contains <style>, and site/preview/candidate.json selects this file as the public reference source. Running the builder reproduces an AssertionError. Since .github/workflows/pages-publish.yml:59 invokes that builder, this change prevents publication of the preview and its aliases. Update the builder's validation to accept the external-stylesheet architecture alongside this extraction.

AGENTS.md reference: AGENTS.md:L7-L7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

Final GUI authority clarification for CSS V28: The user-approved product is ONLY https://masarray.github.io/arsonmix/preview/ (current internal HTML/WIRE/FX/fader source plus approved site/preview-buttons/assets PNG hardware-button CSS/JS/sprite). Bare /preview-v2/ appearance is explicitly rejected, and its public URL is redirect-only. Before merging, ensure V28 remains byte/render/interaction-compatible with generated dist-pages/preview/index.html and approved PNG hardware keys, not merely isolated bare-v2 screenshot. Do not introduce a second public/native GUI. The single GUI release test is tests/single_preview_publication_contract_test.py; Pages must continue to pass.

@masarray
masarray force-pushed the css/v28-chrome-owner-v59-smart-ci-20261104 branch from b3221ca to 1620a90 Compare November 4, 2026 12:13
@masarray masarray changed the title CSS V28 — Eliminate 13 KB inline console CSS, preserve exact V59 cascade and smart CI CSS V28 — Reconcile 13 KB inline CSS into Chrome owner; preserve ONLY approved /preview/ Nov 4, 2026
@masarray
masarray merged commit d4a2f20 into main Nov 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant