Skip to content

WIRE C1: canonical v8 intent + native accepted EdgeId snapshot on installed PCM path - #384

Merged
masarray merged 3 commits into
milestone/m5-universal-channelid-vst3-lease-migration-20261101from
work/wire-c1-native-v8-intent-snapshot-20261104
Nov 4, 2026
Merged

masarray merged 3 commits into
milestone/m5-universal-channelid-vst3-lease-migration-20261101from
work/wire-c1-native-v8-intent-snapshot-20261104

Conversation

@masarray

@masarray masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Installed ENGINE #266 path, not a second router

  • Reuse LiveConsoleBridgeV6::processNativeBusIntent and the existing atomic LiveAudioEngine → LiveDryRoutingLab WIRE publisher; public v8 APPLY_WIRE_TRANSACTION takes standard deviceEpoch/baseGraphRevision/baseRosterRevision/targetChannelId/payload.changes without private NATIVE_* revision fields.
  • Only when JUCE reports an actual installed native ChannelId PCM graph + native-supported WIRE operation does the v8 snapshot expose graph.channels[], graph.edges[], accepted graph/roster revisions and the one supported operation. GUI must use same-revision ACK then accepted snapshot; no JS PCM or invented routing.
  • Preserve scoped NATIVE_APPLY_WIRE_TRANSACTION for existing clients without a second mutation path; native decoder, VST3 lease and graph compiler unchanged. Main WebView event forwards generic v8 operation to the same native handler.
  • Public productionCallbackLive remains false until full VST3/Show/monitor parity and hardware P0 — Crackling with 0 VST3: diagnose WASAPI clock/input/output buffering before engine expansion #15 FAT are qualified. No GUI/CSS changes.
  • Native C++ regression adds >2^53 epoch, accepted EdgeId provenance, valid v8 batch ACK with correct graph/roster revision, duplicate request and stale rollback, and matching accepted follow-up snapshot.

Integration gate: exact SHA Windows Native CTest/PE and native WebView smoke required before merging into #266. GUI #271 and FAT #270 owners must consume graph.edges[] and revised snapshot on same combined SHA, not rely on Pages simulation. No release or user test claim.

@masarray
masarray marked this pull request as ready for review November 4, 2026 10:29
@masarray
masarray merged commit 42c3cfd into milestone/m5-universal-channelid-vst3-lease-migration-20261101 Nov 4, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T10:30:17.590883Z a9fd4d6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

Cross-lane C1 admission blocker found during main V59 reconciliation: PR #385 adds the exact GUI→native owner handoff and additive conditional v8 wire projection to main. src/LiveDryRoutingLab.h::nativeBusStatus() currently exports internal rows (format, parallelSends, primaryOutput) and edges (edgeId/from/to/tap/gainLinear but no enabled/signalKind), while web/mixer-layout.js in GUI #271 requires processingFormat, sends[], graph.mainChannelId, and edge.enabled/signalKind before accepting a WIRE snapshot. Additionally C1 keeps productionCallbackLive=false while #271 rejects nonempty universal graphs/ops in that state. Please normalize from actual installed PCM/verified pins only and align a strictly fenced NATIVE WIRE ACCEPTED / NOT PRODUCT LIVE readback in GUI #271. Do not flip productionCallbackLive=true for convenience; keep single callback/PCM authority and same-revision ACK + subsequent snapshot. C1 isolated green tests cannot yet establish that WebView can consume this shape. Joined Windows #270 FAT remains gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant