Repository navigation
GUI V59: publish selected-only WIRE, quiet collapse, custom OUT independent of MAIN - #383
Conversation
…s to selected edge
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9551e5ca4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if(chosenEdge&&!folded)node.setAttribute('data-wire-main-edge',String(chosenEdge.id)); | ||
| else node.removeAttribute('data-wire-main-edge'); |
There was a problem hiding this comment.
Prevent MAIN dragging from falling back to an undisplayed edge
When CH2 has no direct MAIN edge, arm CH1 OUT and click CH2 IN to connect CH1→CH2. CH2 becomes selected while CH1 remains pinned, so this code removes MAIN's displayed edge identity. However, the MAIN pointerdown handler still falls back to wireFor(activeSource.id, receiver.id) when no focused edge exists. Dragging the now-empty MAIN jack into the WIRE bay therefore disconnects CH1→MAIN, even though CH2 is selected and no plug is displayed. Reject MAIN unplug gestures without the displayed exact edge ID rather than falling back to the pinned source.
AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
| const source=dragging?wireSourceTrack(wireGesture.sourceId): | ||
| (focus||selection().find(t=>t.kind!=='master')||null); | ||
| (selectedChannels.length===1?selectedChannels[0]:null); |
There was a problem hiding this comment.
Keep hover previews bound to the pinned patch source
After arming CH1 OUT and clicking CH2 IN, CH2 is selected but CH1 remains the pinned patch source. With this change, hovering CH3 IN makes the existing preview branch construct a CH2→CH3 cable using source.id and CH2's color, while clicking that same IN still connects CH1→CH3 through armedWireSource(). Previously both used CH1. Keep committed-route inspection selected-only, but render new-route previews from the pinned source so the cable shown before a click matches the route that will actually be created.
Useful? React with 👍 / 👎.
Continuation of #377 built on merged Packet A #376. MAIN physical fragment only for uniquely selected channel, zero folded physical cables/pseudo tails, default CH→MAIN graph retained but excluded from OUT LED and folded activity. Unrelated SVG routes are never drawn; pinned OUT retains patch control independent of selected display. Updates Chromium tests and cache key. Pages publication only after green CI on main; protect fader/meter/FX and native graph. Supersedes conflicted draft #377 after validation.