Skip to content

GUI V59: publish selected-only WIRE, quiet collapse, custom OUT independent of MAIN - #383

Merged
masarray merged 14 commits into
mainfrom
gui/v59-main-pages-selected-wire-quiet-collapse-20261104
Nov 4, 2026
Merged

masarray merged 14 commits into
mainfrom
gui/v59-main-pages-selected-wire-quiet-collapse-20261104

Conversation

@masarray

@masarray masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Continuation of #377 built on merged Packet A #376. MAIN physical fragment only for uniquely selected channel, zero folded physical cables/pseudo tails, default CH→MAIN graph retained but excluded from OUT LED and folded activity. Unrelated SVG routes are never drawn; pinned OUT retains patch control independent of selected display. Updates Chromium tests and cache key. Pages publication only after green CI on main; protect fader/meter/FX and native graph. Supersedes conflicted draft #377 after validation.

@masarray
masarray marked this pull request as ready for review November 4, 2026 09:50
@masarray
masarray merged commit f182e67 into main Nov 4, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T09:52:54.852895Z c9551e5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9551e5ca4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1599 to +1600
if(chosenEdge&&!folded)node.setAttribute('data-wire-main-edge',String(chosenEdge.id));
else node.removeAttribute('data-wire-main-edge');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Prevent MAIN dragging from falling back to an undisplayed edge

When CH2 has no direct MAIN edge, arm CH1 OUT and click CH2 IN to connect CH1→CH2. CH2 becomes selected while CH1 remains pinned, so this code removes MAIN's displayed edge identity. However, the MAIN pointerdown handler still falls back to wireFor(activeSource.id, receiver.id) when no focused edge exists. Dragging the now-empty MAIN jack into the WIRE bay therefore disconnects CH1→MAIN, even though CH2 is selected and no plug is displayed. Reject MAIN unplug gestures without the displayed exact edge ID rather than falling back to the pinned source.

AGENTS.md reference: AGENTS.md:L3-L3

Useful? React with 👍 / 👎.

Comment on lines 1615 to +1616
const source=dragging?wireSourceTrack(wireGesture.sourceId):
(focus||selection().find(t=>t.kind!=='master')||null);
(selectedChannels.length===1?selectedChannels[0]:null);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep hover previews bound to the pinned patch source

After arming CH1 OUT and clicking CH2 IN, CH2 is selected but CH1 remains the pinned patch source. With this change, hovering CH3 IN makes the existing preview branch construct a CH2→CH3 cable using source.id and CH2's color, while clicking that same IN still connects CH1→CH3 through armedWireSource(). Previously both used CH1. Keep committed-route inspection selected-only, but render new-route previews from the pinned source so the cable shown before a click matches the route that will actually be created.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant