Skip to content

WIRE Packet B2: stable native EdgeId, atomic CONNECT/REMOVE/RETARGET/ROUTE_ONLY and PCM tests - #379

Merged
masarray merged 15 commits into
milestone/m5-universal-channelid-vst3-lease-migration-20261101from
work/wire-b2-atomic-native-transactions-20261104
Nov 4, 2026
Merged

masarray merged 15 commits into
milestone/m5-universal-channelid-vst3-lease-migration-20261101from
work/wire-b2-atomic-native-transactions-20261104

Conversation

@masarray

@masarray masarray commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Canonical ENGINE B2 reconciliation (#379 + #380 + #382)

Sole native implementation, no second DSP engine: stable ChannelSendRef.edgeId; atomic control-thread CONNECT/REMOVE/RETARGET/ROUTE_ONLY using one DynamicChannelRoster; duplicate/cycle/physical/budget rejection through existing prepared-PCM compiler; same RealtimeRoutePublisher, DynamicNativeSessionPublisher and VST lease bank used by production JUCE callback.

Reconciled at de347b32123ee3523f2bc7d743631b752e1ce305:

Current scope / safety: only the installed native ChannelId PCM path authorizes scoped native op. Public universal graph productionCallbackLive and generic APPLY_WIRE_TRANSACTION remain fail-closed until GUI #271 + combined FAT #270 and Show/VST migration qualify. Existing GUI visual untouched; #15 physical crackle unresolved.

Integration gate: exact-head Windows MSVC/CTest must PASS, then merge THIS PR into ENGINE sole-owner branch #266 (not into main), supersede #380/#382 after reconciling any remaining independent deltas. No user UAT or product-ready label before physical FAT.

Refs #192 #266 #271 #270 #15.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

Native WIRE execution checkpoint (exact HEAD b8ebf198310cfe6b38e09180f3fe0405a66166ed): stable EdgeId in the sole ChannelSendRef roster; atomic CONNECT/REMOVE/RETARGET/ROUTE_ONLY through DynamicAcceptedSession and installed LiveDryRoutingLab::nativePublisher_; LiveAudioEngine hardware fence; existing scoped native WebView intent/ACK and readback nativeBus.edges[]. New-channel POST MAIN edge is created in ONE roster edit; saved disconnected lanes are not repaired. Native PCM regression covers direct vs 1/2/3-hop impulse, fan-out, exact unplug, retarget identity, stale/cyclic rejection and snapshot fidelity; native bridge mock covers malformed decimal/duplicate intent. Windows exact-head CI run 41792751398 remains running — NOT A PASS YET. This is not the promoted top-level v8 GUI callback contract: APPLY_WIRE_TRANSACTION in root capabilities, full WebView GUI #271 integration, armed-output seamless structural swaps, true Windows hardware FAT and #15 remain blocked. Do not merge into sole owner #266 or call READY FOR USER TEST before exact-head PASS and integration gates.

@masarray
masarray marked this pull request as ready for review November 4, 2026 09:14
@masarray
masarray merged commit e6a92d1 into milestone/m5-universal-channelid-vst3-lease-migration-20261101 Nov 4, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T09:15:09.423827Z de347b3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant