Repository navigation
WIRE Packet B2: stable native EdgeId, atomic CONNECT/REMOVE/RETARGET/ROUTE_ONLY and PCM tests - #379
Conversation
…epted PCM session
…ed roster revision
…d channel remains disconnected
|
Native WIRE execution checkpoint (exact HEAD |
…d rollback safety
…out device reconfigure
e6a92d1
into
milestone/m5-universal-channelid-vst3-lease-migration-20261101
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Canonical ENGINE B2 reconciliation (#379 + #380 + #382)
Sole native implementation, no second DSP engine: stable
ChannelSendRef.edgeId; atomic control-thread CONNECT/REMOVE/RETARGET/ROUTE_ONLY using oneDynamicChannelRoster; duplicate/cycle/physical/budget rejection through existing prepared-PCM compiler; sameRealtimeRoutePublisher,DynamicNativeSessionPublisherand VST lease bank used by production JUCE callback.Reconciled at
de347b32123ee3523f2bc7d743631b752e1ce305:NATIVE_APPLY_WIRE_TRANSACTION, installedLiveAudioEngine/LiveDryRoutingLabhook and accepted EdgeId snapshot preserved.wireTransactionedited first and returned editRejected. Fixed by rejecting stale device before edge mutation, with explicitstaleDevicenative fault and test. 53/54 prior tests passed; latest exact-head Windows run pending.createdEdgeIdson all unaccepted graph publication paths; regression checks stale device, cyclic graph, duplicate edge, primary cable identity, armed safe update, changed device patch rejected, one-block direct/3-hop impulse.Current scope / safety: only the installed native ChannelId PCM path authorizes scoped native op. Public universal graph
productionCallbackLiveand genericAPPLY_WIRE_TRANSACTIONremain fail-closed until GUI #271 + combined FAT #270 and Show/VST migration qualify. Existing GUI visual untouched; #15 physical crackle unresolved.Integration gate: exact-head Windows MSVC/CTest must PASS, then merge THIS PR into ENGINE sole-owner branch #266 (not into main), supersede #380/#382 after reconciling any remaining independent deltas. No user UAT or product-ready label before physical FAT.
Refs #192 #266 #271 #270 #15.