Skip to content

GUI V56 — moderate inset fader well, inset endcaps, thumb+2px pocket and restored subtle cyan tail - #372

Closed
masarray wants to merge 10 commits into
mainfrom
gui/v56-moderate-fader-well-20261104
Closed

masarray wants to merge 10 commits into
mainfrom
gui/v56-moderate-fader-well-20261104

Conversation

@masarray

@masarray masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Owner visual correction after V52/V54 regression

Scope: ONLY physical fader material and small density width calibration. No changes to native engine, FX, WIRE, audio routing, V51 meter/peak hold, or JS fader mapping.

  • Make the fader chassis one continuous matte graphite panel; remove the bright standalone perimeter ring around each fader box.
  • Set a moderately recessed pocket with flat central section and restrained left/right shading. Crucially, pocket ends stop 10px inside both top/bottom of the fader box; not a full-height pill.
  • Well is 2px wider than the approved thumb at all densities: Comfort 29/27, Standard 29/27, Compact 27/25. Retains original silver/rose PNG artwork and approved 5px groove.
  • Thumb may extend above/below pocket at range limits; use existing fader travel and 54/50px thumb height, no cropping or gain math changes.
  • Restore soft narrow cyan tail light only in the 5px black groove below the thumb, using existing --fader-y variable; no new compositing animation.
  • Preserve V54 static lower thumb shadows, no CSS filters, runtime timers or new DOM.
  • Existing mixer-fader-assembly.css owner amended in place, obsolete duplicate fader face removed; cache key updated. V51 meter CSS SHA e168fe3fde3b176ce46f2c637a17db65bc510944 remains byte-identical.

Verification gate

New Chromium V56 1366/1680/1920 × Comfort/Standard/Compact verifies inset lip sizes, pocket-vs-thumb width, unified scale surface, 5px slot, tail color, original meter geometry, fader upper/lower overtravel and pointer input. Emits screenshots for human visual review; existing V52/V51/M1/history tests must also pass.

Do not merge solely on CSS/functional green: compare screenshots to user-supplied pro-mixer reference; no new independent black rectangles or rounded well protruding into margins. Pages public preview only after approved merge & deployment.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

Coordination with merged-main GUI V55 PR #373 (user-requested): the fader thumb must cast a perceptible, low-cost raised shadow from its original silver/rose PNG without CSS filter/RAF. PR #373 updates only cap shadow to 0 4px 6px -1px #000f, 2px 10px 13px -3px #000e, 0 17px 17px -7px #000b, while preserving V52 geometry. Your V56 fader-pocket geometry branch #372 must preserve this cap shadow and rebase after #373, not overwrite it with the V54 smaller shadow. V56 remains independent, unmerged pending exact-head review; do not force merge the older fader owner. See #351 for latest GUI checkpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant