Repository navigation
Conversation
…hover occluded leakage
…y/native/standalone
…ointers with main
…asked key behavior
…e instead of legacy innerText
…, capture V5 ON screenshot
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3315d5f574
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div class="modal hidden identity-overlay" id="channelIdentity" role="dialog" aria-modal="true" aria-label="Edit channel identity"><div class="identity-panel"><div class="identity-top"><div class="identity-kicker">ARSONMIX · CHANNEL <span id="identityIndex">01</span></div><button class="identity-close" id="identityCancel" aria-label="Close channel editor">×</button></div><div class="identity-heading">Channel Properties</div><label class="identity-label" for="identityName">NAME</label><input type="text" id="identityName" maxlength="26" placeholder="Channel name" autocomplete="off"><div class="identity-label">ICON</div><div id="identityIcons" class="identity-icons"></div><div class="identity-label">STRIP COLOR</div><div id="identityColors" class="identity-colors"></div><div class="identity-actions"><button id="identitySave">APPLY CHANGES</button></div></div></div><div class="toast" id="toast" role="status"></div><div class="modal hidden" id="pluginModal" role="dialog" aria-modal="true" aria-label="Choose VST plugin"><div class="modal-panel"><div class="modal-head"><div><span class="eyebrow">VST3 FX BROWSER</span><h2>Choose an effect</h2><p id="pluginTarget">Select a processor to insert in the chain</p></div><button id="closeBrowser" class="chrome-icon" aria-label="Close plugin browser">×</button></div><input id="pluginSearch" class="plugin-search" placeholder="Search by effect, category, plugin name..." autocomplete="off"><div class="plugin-categories"><button class="active" data-category="All">All</button><button data-category="Dynamics">Dynamics</button><button data-category="EQ">EQ</button><button data-category="Space">Space</button><button data-category="Creative">Creative</button></div><div id="pluginResults" class="plugin-results"></div><div class="modal-footer">Demo catalog only · Native VST3 scanning and loading not yet connected</div></div></div> | ||
| </div> | ||
| <script src="app.js"></script><script src="plugin-ui.js"></script><script src="bridge.js"></script><script src="monitor.js"></script><script src="mixer-io.js"></script><script src="mixer-layout.js"></script> | ||
| <script src="app.js"></script><script src="plugin-ui.js"></script><script src="bridge.js"></script><script src="monitor.js"></script><script src="mixer-io.js"></script><script src="mixer-layout.js"></script><script src="hardware-keys.js"></script> |
There was a problem hiding this comment.
Embed and serve the hardware-key script in the native app
In the Windows desktop app, this script request cannot be served: CMakeLists.txt:19–20 does not include web/hardware-keys.js in ARMixAssets, and src/Main.cpp's assetFor() has no /hardware-keys.js handler, falling through to std::nullopt. A repository-wide search found no alternative registration. Consequently, none of the new hardware-key rendering runs in the production WebView, although the file-based browser and standalone tests can pass. Add the script to both the embedded asset list and the native resource provider so the desktop console receives the same controls as the standalone bundle.
AGENTS.md reference: AGENTS.md:L27-L27
Useful? React with 👍 / 👎.
User-approved V5 → real ArSonMix console
Port the last locally approved
ArSonMix_Backlit_Mute_Solo_Dark_v5_Clean.htmlhardware-key material into real WebView production UI owned by GUI PR #271, not mock reference #278.Included
web/hardware-keys.jsrenderer with a single SVG text knockout, dark graphite cap, one edge-aligned white shine fading toward both ends.web/styles-src/43-hardware-backlit.cssoverrides broken BTN-180 only on appropriate mixer toggle controls. Runtime opt-in drops legacybtn-180/candyclasses on those buttons.Critical constraints
No native/audio/DSP changes and no inference of native LIVE. The
work/operator-console-v6GUI branch is the integration base; merge this PR there and let GUI #271 retain ownership of main integration. No customer physical sound claim. Legacy CSS still powers navigation and unrelated controls, but must not skin any migrated hardware toggle.Acceptance
python scripts/build_ui_css.py --check;node --check web/hardware-keys.js;python tests/hardware_key_v5_smoke.pyin Chromium, plus full existing GUI smoke. Old tests referring to BTN-180 mixer button face must be reconciled with this owner-selected replacement; they may not be suppressed by removing functional assertions.Status: draft until browser QA and all impacted tests pass.