Skip to content

Publish approved V5 backlit hardware mixer keys on current GitHub Pages /preview-v2/ - #288

Closed
masarray wants to merge 5 commits into
mainfrom
pages/v5-backlit-hardware-controls-20261102
Closed

masarray wants to merge 5 commits into
mainfrom
pages/v5-backlit-hardware-controls-20261102

Conversation

@masarray

@masarray masarray commented Nov 2, 2026

Copy link
Copy Markdown
Owner

Fix owner-reported missing GUI change in public Pages. V5 was integrated in the native GUI workstream (#271 / #286), but /preview-v2/ is served exclusively from main site files, not the GUI branch.

  • Port the V5 physical key material + one SVG cut-out legend to the existing V36 WIRE reference site/preview-v2/index.html without changing routing, FX, WIRE, faders or audio operations.
  • Fix pre-existing CodePen wrapper 3-column squeeze: equal-height MUTE, SOLO, PFL physical keys, red / yellow / cyan semantic LED, masked backlit text and asymmetric 1–2 px edge leakage, white top shine fading at ends, no hover/filter/blur.
  • Keep WIRE V36 multipage and matrix UX intact. Main site links now point to the SAME /preview-v2/ preview with V5 cache bust.
  • Add dedicated Playwright Chromium ON/OFF and independent-click gate to UI smoke and screenshot artifacts. Pages publisher already copies the site/ tree, so the target address remains unchanged.
  • Reference UI only: no native PCM/ASIO/VST3 sound claim.

Owner-reported production URL regression should be considered closed only after exact main SHA has green UI smoke + Pages deploy and public URL is verified.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T16:18:56.138828Z ff6a479 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff6a479b63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const size=w.toFixed(1)+'x'+h.toFixed(1)+'/'+legend;
if(!force&&record.size===size&&button.querySelector(':scope > svg.mx-hw-face'))return;
record.size=size;
button.innerHTML='<span class="mx-hw-screen-reader">'+escapeXml(legend)+'</span>'+svgMarkup(legend,w,h,record.id,PALETTE[record.semantic]);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the intrinsic width of the Sends on Faders button

When the decorator upgrades #sofToggle, this replacement removes its only in-flow content: both .mx-hw-screen-reader and .mx-hw-face are absolutely positioned. Unlike the strip keys, this auto-sized toolbar flex item has no explicit width or flex basis, so it collapses to its horizontal padding and borders, squeezing the SEND legend into an unreadable sliver and greatly reducing the click target. Give the toolbar key an explicit width or retain an in-flow sizing element before replacing its text; the new smoke test only checks strip buttons and does not exercise this control.

Useful? React with 👍 / 👎.

masarray commented Nov 2, 2026

Copy link
Copy Markdown
Owner Author

Superseded by merged PR #289 (main 0f2d5e2c570ac6a206a72cb729ade568aa2e734a). #289 incorporates the approved V5 backlit buttons into the actual /preview-v2/ Pages source while preserving newer WIRE V36 knob alpha-mask and routing changes. Chromium UI smoke and GitHub Pages build/deploy both passed on that exact main SHA; the public landing and preview URLs respond correctly. Closing this older divergent branch PR to prevent accidentally reintroducing stale WIRE HTML. Native PCM/ASIO/VST3 integration remains independently gated under GUI #271 / ENGINE #266 / FAT #270.

@masarray masarray closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant