Repository navigation
Conversation
…hout altering routing
…l WIRE Pages source
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff6a479b63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const size=w.toFixed(1)+'x'+h.toFixed(1)+'/'+legend; | ||
| if(!force&&record.size===size&&button.querySelector(':scope > svg.mx-hw-face'))return; | ||
| record.size=size; | ||
| button.innerHTML='<span class="mx-hw-screen-reader">'+escapeXml(legend)+'</span>'+svgMarkup(legend,w,h,record.id,PALETTE[record.semantic]); |
There was a problem hiding this comment.
Preserve the intrinsic width of the Sends on Faders button
When the decorator upgrades #sofToggle, this replacement removes its only in-flow content: both .mx-hw-screen-reader and .mx-hw-face are absolutely positioned. Unlike the strip keys, this auto-sized toolbar flex item has no explicit width or flex basis, so it collapses to its horizontal padding and borders, squeezing the SEND legend into an unreadable sliver and greatly reducing the click target. Give the toolbar key an explicit width or retain an in-flow sizing element before replacing its text; the new smoke test only checks strip buttons and does not exercise this control.
Useful? React with 👍 / 👎.
|
Superseded by merged PR #289 (main |
Fix owner-reported missing GUI change in public Pages. V5 was integrated in the native GUI workstream (#271 / #286), but /preview-v2/ is served exclusively from main site files, not the GUI branch.
site/preview-v2/index.htmlwithout changing routing, FX, WIRE, faders or audio operations./preview-v2/preview with V5 cache bust.site/tree, so the target address remains unchanged.Owner-reported production URL regression should be considered closed only after exact main SHA has green UI smoke + Pages deploy and public URL is verified.